public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: Eric Kerin <eric@bootseg.com>
Cc: "Larry W. Finger" <Larry.Finger@lwfinger.net>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: Kernel oops in 2.6.1 when loading aha152x_cs.ko
Date: 10 Jan 2004 10:03:20 -0500	[thread overview]
Message-ID: <1073747000.1945.5.camel@mulgrave> (raw)
In-Reply-To: <1073716698.2026.18.camel@opiate>

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

On Sat, 2004-01-10 at 01:38, Eric Kerin wrote:
> Let's try this again, with the proper check. This one even compiles!

Actually, you're still on slightly the wrong track.  The quick fix, as I
told Russell on this list is in aha152x_stub.c.

If you want to code that up as a patch and test it, I'll apply it.

James


[-- Attachment #2: Type: message/rfc822, Size: 3193 bytes --]

From: James Bottomley <James.Bottomley@steeleye.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: Fwd: Kernel Oops with Adaptec 1460D (PCMCIA SCSI-Controller) and Kernel 2.6.0
Date: 08 Jan 2004 13:05:40 -0500
Message-ID: <1073585142.2915.31.camel@mulgrave>

On Thu, 2004-01-08 at 06:29, Russell King wrote:
> Could someone look into this - it seems that it's more of a scsi
> bug than a pcmcia bug.

The problem seems to be this code in aha152x.c:

#ifndef PCMCIA
#define driver_template aha152x_driver_template
#include "scsi_module.c"
#endif

Since it's still behaving as a legacy driver (by calling
register_scsi()), it needs the aha152x_driver_template.legacy_hosts list
initialised (which is done in scsi_module.c).

The true fix would be to convert aha152x to the new API.  However, a
quick fix is probably to add

	INIT_LIST_HEAD(&s.legacy_hosts);

just before the call to aha152x_probe_one() in aha152x_stub.c

James


-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2004-01-10 15:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-09 20:14 Kernel oops in 2.6.1 when loading aha152x_cs.ko Larry W. Finger
2004-01-10  1:37 ` Eric Kerin
2004-01-10  5:27   ` Larry W. Finger
2004-01-10  6:38     ` Eric Kerin
2004-01-10 15:03       ` James Bottomley [this message]
2004-01-10 17:09         ` Larry W. Finger
2004-01-10 17:35         ` Juergen E. Fischer
2004-01-10 19:11         ` Eric Kerin
2004-01-10 20:43           ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1073747000.1945.5.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=eric@bootseg.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox