From: James Bottomley <James.Bottomley@steeleye.com>
To: Jes Sorensen <jes@trained-monkey.org>
Cc: Andrew Morton <akpm@osdl.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [patch] qla1280 compile fix for CONFIG_HOTPLUG in 2.6
Date: 12 Jan 2004 10:11:15 -0500 [thread overview]
Message-ID: <1073920276.2186.11.camel@mulgrave> (raw)
In-Reply-To: <16386.38762.670634.620111@gargle.gargle.HOWL>
On Mon, 2004-01-12 at 07:47, Jes Sorensen wrote:
> -#if defined(CONFIG_SCSI_QLOGIC_1280_MODULE) || (LINUX_VERSION_CODE < 0x020600)
> +#if defined(CONFIG_SCSI_QLOGIC_1280_MODULE) || (LINUX_VERSION_CODE < 0x020600) || defined(CONFIG_HOTPLUG)
I'm not very keen on this. It's mated with the
.remove = __devexit_p(qla1280_remove_one)
so you're second guessing the __devexit_p() semantics with #ifdefs
In what scenario does the __devexit declaration of the function fail?
In the 2.6 kernel, which the #ifdef's are looking for, it should be
placed into a discard section and thus be taken out at link time.
James
prev parent reply other threads:[~2004-01-12 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-12 12:47 [patch] qla1280 compile fix for CONFIG_HOTPLUG in 2.6 Jes Sorensen
2004-01-12 15:10 ` Christoph Hellwig
2004-01-12 15:15 ` Jes Sorensen
2004-01-12 19:37 ` Christoph Hellwig
2004-01-12 15:11 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1073920276.2186.11.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=jes@trained-monkey.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox