From: James Bottomley <James.Bottomley@steeleye.com>
To: Jes Sorensen <jes@trained-monkey.org>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
jeremy@sgi.com
Subject: Re: [patch] qla1280 update for 2.6.1-mm4
Date: 19 Jan 2004 12:03:11 -0500 [thread overview]
Message-ID: <1074531798.1894.17.camel@mulgrave> (raw)
In-Reply-To: <16395.51364.833229.536552@gargle.gargle.HOWL>
On Mon, 2004-01-19 at 07:08, Jes Sorensen wrote:
> I am attaching the latest patch for qla1280, which includes Andrew's and
> James' patches (modulo the 64 bit enable part) as well changes to make
> it handle pci_set_dma_mask() correctly and switch to only use one of the
> two SCSI command issuing versions depending on whether the driver is
> compiled for 64 or 32 bit DMA. The old code effectively did this anyway,
> but with this change it is no longer compiling in the part not used.
OK, put it in the tree, thanks.
Something to think about (I'm not asking you to change it) is whether
you really want to use 64 bit descriptors on all 64 bit machines. The
way the qla1280 single issue queue is organised it looks like we eat up
slots (and, worse, overflow slots) quite a bit faster in 64 bit
addressing mode. Therefore, it seems like the driver would operate more
efficiently in 32 bit mode, so it might be worth a runtime check even on
64 bit machines to see whether the addressing mode is really necessary
(i.e. no physical memory > 4GB for instance).
James
next prev parent reply other threads:[~2004-01-19 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-19 12:08 [patch] qla1280 update for 2.6.1-mm4 Jes Sorensen
2004-01-19 12:14 ` Christoph Hellwig
2004-01-19 12:27 ` Jes Sorensen
2004-01-19 17:03 ` James Bottomley [this message]
2004-01-19 21:18 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1074531798.1894.17.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=jeremy@sgi.com \
--cc=jes@trained-monkey.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox