[patch] Have qla2xxx driver bind fcports.

[patch] Have qla2xxx driver bind fcports.

[Andrew Vasquez]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Andrew/James,

During the removal of the failover and IOCTL code from the 
scsi-qla2xxx-2.6 tree, one critical piece of code (a one-liner) was 
inadvertently removed that effectively disables the drivers ability 
to bind fcports (devices found in the loop or fabric) to the SCSI 
nexus (h/b/t/l).  This could cause users to believe that no devices
would be discovered during driver scans.

BTW: This fix is already in the resync_bk-v8.00.00b9 patch up on the
SF.net site.

Please apply.

Regards,
Andrew Vasquez

[-- Attachment #2: bind_fcports-v8.00.00b8-mm4.diff --]
[-- Type: application/octet-stream, Size: 484 bytes --]

--- linux-2.6.1-mm4/drivers/scsi/qla2xxx/qla_init.c.orig	2004-01-19 08:23:46.924323032 -0800
+++ linux-2.6.1-mm4/drivers/scsi/qla2xxx/qla_init.c	2004-01-19 08:24:48.860907240 -0800
@@ -1592,6 +1592,8 @@
 	if (!atomic_read(&ha->loop_down_timer) &&
 	    !(test_bit(LOOP_RESYNC_NEEDED, &ha->dpc_flags))) {
 
+		qla2x00_config_os(ha);
+
 		/* If we found all devices then go ready */
 		if (!(test_bit(LOGIN_RETRY_NEEDED, &ha->dpc_flags))) {
 			atomic_set(&ha->loop_state, LOOP_READY);

Re: [patch] Have qla2xxx driver bind fcports.

[James Bottomley]

On Mon, 2004-01-19 at 12:03, Andrew Vasquez wrote:
> BTW: This fix is already in the resync_bk-v8.00.00b9 patch up on the
> SF.net site.

Thanks, sorry about that.

As far as the resync goes, I'd like to wait a while just to see if any
more bugs turn up in the ioctl/failover separation piece ... it will be
easier to debug if we have fewer changes, so how does early 2.6.2 sound
for this (depending, of course, on when that actually is)?

James

Re: [patch] Have qla2xxx driver bind fcports.

[Michael W. Shaffer]

> As far as the resync goes, I'd like to wait a while just to
> see if any more bugs turn up in the ioctl/failover separation
> piece ... it will be easier to debug if we have fewer changes,
> so how does early 2.6.2 sound for this (depending, of course,
> on when that actually is)?

Thanks to everyone for figuring this out so quickly. Should I
assume that this fix will be merged into 2.6.1-mm5 or so, and
eventually into 2.6.2? I'll probably continue to do some beta
testing on this system with the patches I have now, but I
would most likely wait until the LUN fix is into the -mm tree
before trying to move into production with it.


__________________________________
Do you Yahoo!?
Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes
http://hotjobs.sweepstakes.yahoo.com/signingbonus

Re: [patch] Have qla2xxx driver bind fcports.

[Andrew Morton]

"Michael W. Shaffer" <mwshaffer@yahoo.com> wrote:
>
> > As far as the resync goes, I'd like to wait a while just to
> > see if any more bugs turn up in the ioctl/failover separation
> > piece ... it will be easier to debug if we have fewer changes,
> > so how does early 2.6.2 sound for this (depending, of course,
> > on when that actually is)?
> 
> Thanks to everyone for figuring this out so quickly. Should I
> assume that this fix will be merged into 2.6.1-mm5 or so, and
> eventually into 2.6.2? I'll probably continue to do some beta
> testing on this system with the patches I have now, but I
> would most likely wait until the LUN fix is into the -mm tree
> before trying to move into production with it.
> 

I added Andrew's patch to -mm.   I'll get -mm5 out today.

James is suggesting 2.6.3-pre for merging this patch.  That may be
conservative: we've only just started in on the post-2.6.1 work, so 2.6.2
is a while off yet.

Re: [patch] Have qla2xxx driver bind fcports.

[Christoph Hellwig]

On Mon, Jan 19, 2004 at 01:49:44PM -0800, Andrew Morton wrote:
> James is suggesting 2.6.3-pre for merging this patch.  That may be
> conservative: we've only just started in on the post-2.6.1 work, so 2.6.2
> is a while off yet.

My understanding is that this small fix should get in ASAP, but the larger
update from qlogic still needs to settle a bit.  Delaying the fix wouldn't
make any sense to me.

RE: [patch] Have qla2xxx driver bind fcports.

[Andrew Vasquez]

On Monday, January 19, 2004 9:11 AM, James Bottomley wrote:
> On Mon, 2004-01-19 at 12:03, Andrew Vasquez wrote:
> > BTW: This fix is already in the resync_bk-v8.00.00b9 patch up on the
> > SF.net site.
> 
> Thanks, sorry about that.
>

No problem.
 
> As far as the resync goes, I'd like to wait a while just to see if any
> more bugs turn up in the ioctl/failover separation piece ...
> it will be
> easier to debug if we have fewer changes, so how does early
> 2.6.2 sound
> for this (depending, of course, on when that actually is)?
>

That's fine, especially since there are some other structural fixups
the community would like to see with respect to the new firmware
images contained in b9.

Regards,
Andrew Vasquez