public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] aha152x-2.6.1
Date: 19 Jan 2004 19:46:31 -0500	[thread overview]
Message-ID: <1074538162.1647.18.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.44.0401172318380.963-100000@poirot.grange>

On Sat, 2004-01-17 at 17:25, Guennadi Liakhovetski wrote:
> Below is a patch for aha152x to fix check / request_region, plus make it
> fail explicitly in the case of busy address-range. Compiles, untested
> (yet).

Actually, the aha152x maintainer has already fixed this (and the fix is
in mainline---and copying the maintainer on changes to his driver would
have been polite).

> While on that - what about the advansys-patch with a similar (check_region
> vs. request_region) scope, I sent earlier to the list - was it wrong, or
> just not important enough?

Erm, this is what you said about the Advansys patch:

"Ok, the attached patch (carefully, I hope) does request_region instead of
check_region for the detection address-range, and then release_region -
when needed. Hope I got it right. Compiles, otherwise completely untested."

which wasn't exactly a ringing endorsement.  If we don't get any
comments or complaints, I'll probably add it to the SCSI patch list.

James



  reply	other threads:[~2004-01-20  0:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-17 22:25 [PATCH] aha152x-2.6.1 Guennadi Liakhovetski
2004-01-20  0:46 ` James Bottomley [this message]
2004-01-20 19:44   ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1074538162.1647.18.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox