Question on qla2xxx Kconfig update in 2.6.2

Question on qla2xxx Kconfig update in 2.6.2

[Mike Anderson]

Is the usage of SCSI_QLA2XXX_CONFIG instead of SCSI_QLA2XXX correct in
drivers/scsi/qla2xxx/Kconfig or have I just not had enough coffee this morning?

After a fresh bk pull and make config I could not get the qla2xxx
directory selected during a make modules. If I change to using SCSI_QLA2XXX in the Kconfig file everything is fine.

-andmike
--
Michael Anderson
andmike@us.ibm.com

Re: Question on qla2xxx Kconfig update in 2.6.2

[James Bottomley]

On Thu, 2004-02-05 at 11:37, Mike Anderson wrote:
> Is the usage of SCSI_QLA2XXX_CONFIG instead of SCSI_QLA2XXX correct in
> drivers/scsi/qla2xxx/Kconfig or have I just not had enough coffee this morning?
> 
> After a fresh bk pull and make config I could not get the qla2xxx
> directory selected during a make modules. If I change to using SCSI_QLA2XXX in the Kconfig file everything is fine.

Erk, my fault.  I quietly fixed it by altering drivers/scsi/Makefile (to
make obj-$(CONFIG_SCSI_QLA2XXX_CONFIG) += qla2xxx/)

but then I apparently lost it from the tree on a rebuild.

I'll add it back.

James

Re: Question on qla2xxx Kconfig update in 2.6.2

[James Bottomley]

On Thu, 2004-02-05 at 11:58, Mike Anderson wrote:
> Should we fix it the other way around (i.e., have qla2xxx Kconfig
> use SCSI_QLA2XXX) to be consistent with other Kconfig users. I see only
> one other in the .config file that I am using that has a _CONFIG postfix.

Well, least line of resistance when things don't work.

But I agree, removing the _CONFIG in qla2xxx/Kconfig does look better.

James

Re: Question on qla2xxx Kconfig update in 2.6.2

[Mike Anderson]

James Bottomley [James.Bottomley@SteelEye.com] wrote:
> On Thu, 2004-02-05 at 11:37, Mike Anderson wrote:
> > Is the usage of SCSI_QLA2XXX_CONFIG instead of SCSI_QLA2XXX correct in
> > drivers/scsi/qla2xxx/Kconfig or have I just not had enough coffee this morning?
> > 
> > After a fresh bk pull and make config I could not get the qla2xxx
> > directory selected during a make modules. If I change to using SCSI_QLA2XXX in the Kconfig file everything is fine.
> 
> Erk, my fault.  I quietly fixed it by altering drivers/scsi/Makefile (to
> make obj-$(CONFIG_SCSI_QLA2XXX_CONFIG) += qla2xxx/)
> 

ok.

Should we fix it the other way around (i.e., have qla2xxx Kconfig
use SCSI_QLA2XXX) to be consistent with other Kconfig users. I see only
one other in the .config file that I am using that has a _CONFIG postfix.

-andmike
--
Michael Anderson
andmike@us.ibm.com

RE: Question on qla2xxx Kconfig update in 2.6.2

[Andrew Vasquez]

On Thursday, February 05, 2004 8:55 AM, James Bottomley wrote:
> On Thu, 2004-02-05 at 11:58, Mike Anderson wrote:
> > Should we fix it the other way around (i.e., have qla2xxx Kconfig
> > use SCSI_QLA2XXX) to be consistent with other Kconfig users. I see
> > only one other in the .config file that I am using that has a
> > _CONFIG postfix. 
> 
> Well, least line of resistance when things don't work.
> 
> But I agree, removing the _CONFIG in qla2xxx/Kconfig does look better.
> 
> James

David Miller had already sent along a patch to me which removes the 
_CONFIG suffix.  I'll attach it here.

--
Andrew Vasquez


===== drivers/scsi/qla2xxx/Kconfig 1.4 vs edited =====
--- 1.4/drivers/scsi/qla2xxx/Kconfig	Mon Feb  2 08:02:05 2004
+++ edited/drivers/scsi/qla2xxx/Kconfig	Wed Feb  4 21:31:12 2004
@@ -1,41 +1,41 @@
-config SCSI_QLA2XXX_CONFIG
+config SCSI_QLA2XXX
 	tristate
 	default (SCSI && PCI)
 	depends on SCSI && PCI
 
 config SCSI_QLA21XX
 	tristate "QLogic ISP2100 host adapter family support"
-	depends on SCSI_QLA2XXX_CONFIG
+	depends on SCSI_QLA2XXX
 	---help---
 	This driver supports the QLogic 21xx (ISP2100) host adapter family.
 
 config SCSI_QLA22XX
 	tristate "QLogic ISP2200 host adapter family support"
-	depends on SCSI_QLA2XXX_CONFIG
+	depends on SCSI_QLA2XXX
 	---help---
 	This driver supports the QLogic 22xx (ISP2200) host adapter family.
 
 config SCSI_QLA2300
 	tristate "QLogic ISP2300 host adapter family support"
-	depends on SCSI_QLA2XXX_CONFIG
+	depends on SCSI_QLA2XXX
 	---help---
 	This driver supports the QLogic 2300 (ISP2300, and ISP2312) host
 	adapter family.
 
 config SCSI_QLA2322
 	tristate "QLogic ISP2322 host adapter family support"
-	depends on SCSI_QLA2XXX_CONFIG
+	depends on SCSI_QLA2XXX
 	---help---
 	This driver supports the QLogic 2322 (ISP2322) host adapter family.
 
 config SCSI_QLA6312
 	tristate "QLogic ISP6312 host adapter family support"
-	depends on SCSI_QLA2XXX_CONFIG
+	depends on SCSI_QLA2XXX
 	---help---
 	This driver supports the QLogic 6312 (ISP6312) host adapter family.
 
 config SCSI_QLA6322
 	tristate "QLogic ISP6322 host adapter family support"
-	depends on SCSI_QLA2XXX_CONFIG
+	depends on SCSI_QLA2XXX
 	---help---
 	This driver supports the QLogic 6322 (ISP6322) host adapter family.