From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] qla2xxx -- FCP_RSP IU check during command completion.
Date: Tue, 10 Feb 2004 15:17:18 -0800 [thread overview]
Message-ID: <1076455038.6072.62.camel@dieplab1> (raw)
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
James,
While processing command completions in qla2x00_status_entry()
interrogate the FCP_RSP IU in case of any FCP protocol errors (FCP-3,
9.4.11) during command execution. If there were any failures, schedule
a retry of the command via DID_BUS_BUSY.
Please apply.
Regards,
Andrew Vasquez
[-- Attachment #2: Type: text/plain, Size: 1101 bytes --]
--- a/drivers/scsi/qla2xxx/qla_isr.c 2004-02-02 09:38:29.000000000 -0800
+++ b/drivers/scsi/qla2xxx/qla_isr.c 2004-02-10 13:51:30.474292736 -0800
@@ -828,6 +828,7 @@
uint8_t lscsi_status;
uint32_t resid;
uint8_t sense_sz = 0;
+ uint16_t rsp_info_len;
/* Fast path completion. */
if (le16_to_cpu(pkt->comp_status) == CS_COMPLETE &&
@@ -919,6 +920,23 @@
}
}
+ /* Check for any FCP transport errors. */
+ if (scsi_status & SS_RESPONSE_INFO_LEN_VALID) {
+ rsp_info_len = le16_to_cpu(pkt->rsp_info_len);
+ if (rsp_info_len > 3 && pkt->rsp_info[3]) {
+ DEBUG2(printk("scsi(%ld:%d:%d:%d) FCP I/O protocol "
+ "failure (%x/%02x%02x%02x%02x%02x%02x%02x%02x)..."
+ "retrying command\n", ha->host_no, b, t, l,
+ rsp_info_len, pkt->rsp_info[0], pkt->rsp_info[1],
+ pkt->rsp_info[2], pkt->rsp_info[3],
+ pkt->rsp_info[4], pkt->rsp_info[5],
+ pkt->rsp_info[6], pkt->rsp_info[7]));
+
+ cp->result = DID_BUS_BUSY << 16;
+ return;
+ }
+ }
+
/*
* Based on Host and scsi status generate status code for Linux
*/
next reply other threads:[~2004-02-10 23:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 23:17 Andrew Vasquez [this message]
2004-02-10 23:44 ` [PATCH] qla2xxx -- FCP_RSP IU check during command completion Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1076455038.6072.62.camel@dieplab1 \
--to=andrew.vasquez@qlogic.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox