Re: *solved* megaraid /proc under kernel 2.6.2

[Paul Wagland <paul@kungfoocoder.org>]

Hi all,

OK, I now know what the problem is with the /proc entries and the
megaraid driver.

It turns out that pci_driver.probe member (in this case
megaraid_probe_one()) is called before the module_init() declared
function, in this case megaraid_init().

The problem is as follows: megaraid_probe_one calls
mega_create_proc_entry() which relies on the fact that megaraid_init()
has already been called. Except, that this fact isn't :-)

So, now that I know what the problem is, does anyone know where the bug
really lies? I.e;

Should megaraid_init() be called before megaraid_probe_one() is called?
That would make this a "kernel bug", for some suitable value of kernel.

or

Should megaraid_probe_one() not rely on megaraid_init() having been
previously called? This would then turn it into a driver bug.


If the latter, when I go in to fix this code, can I assume that
megaraid_probe_one() will only be called once at a time, i.e. that there
is a lock somewhere outside of me that guarantees that I don't have to
worry about re-entrancy issues. Please note that the code already
assumes this!

Should this be asked on linux-kernel?

Thanks in advance for all replies,
Paul