public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Andi Kleen <ak@suse.de>
Cc: "Moore, Eric Dean" <Emoore@lsil.com>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: Fusion problems with 2.6.5rc1 on AMD x86-64 IV
Date: 17 Mar 2004 11:34:45 -0500	[thread overview]
Message-ID: <1079541289.2135.2.camel@mulgrave> (raw)
In-Reply-To: <20040317165355.37c846f0.ak@suse.de>

> The problem seems to be the broke consistent dma mask.
> 
> I currently just mask it with 0xffffffff in pci_alloc_consistent
> and why that workaround it works.

Well, I don't understand this.

The place it's setup is in pci/probe.c:

--- 1.60/drivers/pci/probe.c    Wed Feb 18 17:41:09 2004
+++ 1.61/drivers/pci/probe.c    Sun Mar 14 14:17:06 2004
@@ -570,7 +570,6 @@
        /* Assume 32-bit PCI; let 64-bit PCI cards (which are far rarer)
           set this higher, assuming the system even supports it.  */
        dev->dma_mask = 0xffffffff;
-       dev->consistent_dma_mask = 0xffffffff;
        if (pci_setup_device(dev) < 0) {
                kfree(dev);
                return NULL;
@@ -582,6 +581,7 @@
        pci_name_device(dev);
 
        dev->dev.dma_mask = &dev->dma_mask;
+       dev->dev.coherent_dma_mask = 0xffffffffull;
 
        return dev;

The only reason I can see having a screw up is if some untoward
manipulation is going on in pci_setup_device().  This shouldn't be
because the pci->dev isn't initialised until after that (which is why
the coherent_dma_mask initialisation had to be moved further back).

You can verify this by moving the device_initialize() and the
coherent_dma_mask assignment above pci_setup_device.

James



  reply	other threads:[~2004-03-17 16:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-17 15:58 Fusion problems with 2.6.5rc1 on AMD x86-64 IV Moore, Eric Dean
2004-03-17 15:53 ` Andi Kleen
2004-03-17 16:34   ` James Bottomley [this message]
     [not found] <20040317024917.630dcb86.ak@suse.de>
     [not found] ` <20040317060332.36d492ab.ak@suse.de>
2004-03-17  9:00   ` Fusion problems with 2.6.5rc1 on AMD x86-64 III Andi Kleen
2004-03-17  9:06     ` Fusion problems with 2.6.5rc1 on AMD x86-64 IV Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1079541289.2135.2.camel@mulgrave \
    --to=james.bottomley@hansenpartnership.com \
    --cc=Emoore@lsil.com \
    --cc=ak@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox