From: James Bottomley <James.Bottomley@steeleye.com>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH] Fix error handler offline behaviour
Date: 17 Mar 2004 11:47:25 -0500 [thread overview]
Message-ID: <1079542049.2137.6.camel@mulgrave> (raw)
In-Reply-To: <547AF3BD0F3F0B4CBDC379BAC7E4189F64E6BB@otce2k03.adaptec.com>
On Wed, 2004-03-17 at 11:29, Salyzyn, Mark wrote:
> There was a scsi_device_online(Sdev) handler used in the patch, why not
> a scsi_device_set_online(Sdev) and a scsi_device_set_offline(Sdev)?
Because I want to abstract out the online checks. At the moment it's
simply != SDEV_OFFLINE, but this might change.
Firstly, at the moment, the state model has *two* possible transitions
for SDEV_OFFLINE, so a function setting online wouldn't necessarily know
where to go and secondly I'm dubious about the wisdom of drivers
actually mucking with the online flags and certainly don't want to
encourage it.
James
next prev parent reply other threads:[~2004-03-17 16:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-17 16:29 [PATCH] Fix error handler offline behaviour Salyzyn, Mark
2004-03-17 16:32 ` Matthew Wilcox
2004-03-17 16:47 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-03-17 18:16 Salyzyn, Mark
2004-03-17 16:46 Salyzyn, Mark
2004-03-16 22:31 James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1079542049.2137.6.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox