public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: Manish Kumar Bhojasia <mbhojasi@cisco.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
	"Linux-Iscsi-Devel@Lists.  Sourceforge. Net"
	<linux-iscsi-devel@lists.sourceforge.net>
Subject: Re: [PATCH] Updated iscsi driver 4.0.1.2
Date: 26 Mar 2004 12:20:46 -0500	[thread overview]
Message-ID: <1080321647.2031.51.camel@mulgrave> (raw)
In-Reply-To: <FFEFJMNKOMGHNFBIAHOCOEHPDGAA.mbhojasi@cisco.com>

On Fri, 2004-03-26 at 11:05, Manish Kumar Bhojasia wrote:
> Please review and let us know your comments.

Thanks for moving this to iscsi-sfnet.  I think the config option and
the module name need to follow suit (I also note that the printk id
strings still say Cisco iSCSI driver).

I still get a compile failure:

  CC [M]  drivers/scsi/iscsi-sfnet/iscsi-debug-attr.o
cc1: warnings being treated as errors
drivers/scsi/iscsi-sfnet/iscsi-debug-attr.c: In function
`iscsi_target_printcmnd':
drivers/scsi/iscsi-sfnet/iscsi-debug-attr.c:977: warning: int format,
different type arg (arg 4)
make[3]: *** [drivers/scsi/iscsi-sfnet/iscsi-debug-attr.o] Error 1
make[2]: *** [drivers/scsi/iscsi-sfnet] Error 2
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

This looks to be because of -Werror rather than anything serious.

James



  reply	other threads:[~2004-03-26 17:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-26 16:05 [PATCH] Updated iscsi driver 4.0.1.2 Manish Kumar Bhojasia
2004-03-26 17:20 ` James Bottomley [this message]
2004-03-30 14:33   ` Manish Kumar Bhojasia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1080321647.2031.51.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=linux-iscsi-devel@lists.sourceforge.net \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mbhojasi@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox