From: James Bottomley <James.Bottomley@steeleye.com>
To: Masao Fukuchi <fukuchi.masao@jp.fujitsu.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] improvement of fastfail operation
Date: 30 Mar 2004 20:29:52 -0500 [thread overview]
Message-ID: <1080696593.2075.120.camel@mulgrave> (raw)
In-Reply-To: <200403291217.AA03115@fukuchi.jp.fujitsu.com>
On Mon, 2004-03-29 at 07:17, Masao Fukuchi wrote:
> By the way, how about item 1.
> I think this is bug and we need to validate fastfail for command timeout.
> If you agree with this, please put it into official patch.
> (See attached patch)
Well, the patch doesn't apply, but I put an equivalent in the tree.
> Next, I tested the fastfail recovery using Kernel 2.6.4.
> But the command didn't complete forever.
> Then I installed following Mike Christie's patch and it worked fine.
> http://marc.theaimsgroup.com/?l=linux-scsi&m=107904932710899&w=2
> Please put it into official patch.
This patch is obviously wrong on its face. It completes the request
without regard to any leftovers.
There's clearly a problem somewhere in the completion path for commands
that run out of retries, but whatever it is, this patch only covers it
up it doesn't solve the root problem.
James
next prev parent reply other threads:[~2004-03-31 1:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-24 0:38 [PATCH] improvement of fastfail operation Masao Fukuchi
2004-03-27 15:57 ` James Bottomley
2004-03-29 10:20 ` Mike Christie
2004-03-29 12:17 ` Masao Fukuchi
2004-03-31 1:29 ` James Bottomley [this message]
2004-03-31 5:14 ` Mike Christie
2004-03-31 22:04 ` Jens Axboe
2004-03-31 22:11 ` James Bottomley
2004-03-31 22:12 ` Jens Axboe
2004-03-31 23:15 ` Mike Christie
2004-04-01 6:47 ` Jens Axboe
[not found] ` <406BC50E.6090100@us.ibm.com>
2004-04-01 7:53 ` Mike Christie
2004-04-01 15:06 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1080696593.2075.120.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=fukuchi.masao@jp.fujitsu.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox