From: James Bottomley <James.Bottomley@steeleye.com>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] qla2xxx: sleep while IRQ disabled fix in eh_abort
Date: 01 Apr 2004 10:04:41 -0500 [thread overview]
Message-ID: <1080831910.2118.6.camel@mulgrave> (raw)
In-Reply-To: <20040401061740.GA14121@praka.local.home>
On Thu, 2004-04-01 at 01:17, Andrew Vasquez wrote:
> Attached is a patch which fixes a problem in qla2xxx_eh_abort() where
> we incorrect use spin_unlock() before calling qla2x00_abort_command()
> - which can of course sleep.
Well, actually, sleeping with interrupts disabled is only a minor bug.
Assuming they'll be disabled when you return from a sleep is the major
bug because if you take the host lock again without disabling
interrupts, you'll deadlock on a SCSI interrupt.
Regardless, this patch doesn't look right. Flags contains interrupt
state. If you actually go around the for loop, you set the state
unconditionally to disabled because of the
spin_lock_irq(ha->host->host_lock);
spin_lock_irqsave(&ha->hardware_lock, flags);
James
next prev parent reply other threads:[~2004-04-01 15:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 5:34 [PATCH] ibmvscsi driver - third version Dave Boutcher
2004-02-25 13:45 ` Christoph Hellwig
2004-02-25 17:53 ` [PATCH] ibmvscsi driver - fourth version Dave Boutcher
2004-03-11 17:43 ` James Bottomley
2004-03-11 21:25 ` Dave Boutcher
2004-03-11 22:07 ` James Bottomley
2004-03-12 15:59 ` [PATCH] ibmvscsi driver - fifth version Dave Boutcher
2004-03-31 21:26 ` [PATCH] ibmvscsi driver - sixth version Dave Boutcher
2004-03-31 21:58 ` James Bottomley
2004-03-31 22:37 ` Dave Boutcher
2004-03-31 22:02 ` Jeff Garzik
2004-03-31 23:12 ` Dave Boutcher
2004-03-31 23:39 ` James Bottomley
2004-03-31 23:51 ` Dave Boutcher
2004-04-01 0:10 ` Jeff Garzik
2004-04-01 6:17 ` [PATCH] qla2xxx: sleep while IRQ disabled fix in eh_abort Andrew Vasquez
2004-04-01 15:04 ` James Bottomley [this message]
2004-04-01 0:16 ` [PATCH] ibmvscsi driver - sixth version Jeff Garzik
2004-04-01 6:03 ` Andrew Vasquez
2004-04-01 7:13 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1080831910.2118.6.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=andrew.vasquez@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox