Re: [PATCH] improvement of fastfail operation

Jens Axboe
2004-04-01T06:48:31Z

On Wed, Mar 31 2004, Mike Christie wrote:
> Jens Axboe wrote:
> >On Wed, Mar 31 2004, James Bottomley wrote:
> >
> >>On Wed, 2004-03-31 at 17:04, Jens Axboe wrote:
> >>
> >>>So the new patch you sent with this mail is no good. Your previous one
> >>>should be adopted ;-)
> >>
> >>And the:
> >>
> >>
> >> if (blk_pc_request(req))
> >> leftover = req->data_len - bytes;
> >>
> >>Since end_that_request chunk won't muck with that, is that OK?
> >
> >
> >It's a bit messy right now really, but it's up to the drivers to modify
> >that one. So for partial completions, it should be updated to be
> >
> > leftover = req->data_len;
> >
> >as well.
> >
>
> Is that a typo? If drivers are to account for it, scsi should do
> leftover = req->data_len - bytes;
> ?

No, scsi_io_completion() should already have done it.

--
Jens Axboe