Re: [PATCH] improvement of fastfail operation

James Bottomley
2004-03-31T01:30:03Z

On Mon, 2004-03-29 at 07:17, Masao Fukuchi wrote:
> By the way, how about item 1.
> I think this is bug and we need to validate fastfail for command timeout.
> If you agree with this, please put it into official patch.
> (See attached patch)

Well, the patch doesn't apply, but I put an equivalent in the tree.

> Next, I tested the fastfail recovery using Kernel 2.6.4.
> But the command didn't complete forever.
> Then I installed following Mike Christie's patch and it worked fine.
> http://marc.theaimsgroup.com/?l=linux-scsi&m=107904932710899&w=2
> Please put it into official patch.

This patch is obviously wrong on its face. It completes the request
without regard to any leftovers.

There's clearly a problem somewhere in the completion path for commands
that run out of retries, but whatever it is, this patch only covers it
up it doesn't solve the root problem.

James