Re: sym2 probs in bk-scsi tree

[James Bottomley <James.Bottomley@steeleye.com>]

On Thu, 2004-04-08 at 09:57, Matthew Wilcox wrote:
> They certainly are scary.  What is device 15 on this scsi bus?  This
> looks like domain validation being applied to a device that can't do it
> to me.  Did I get that right, James?

OK, try the attached, it should predicate DV on what we already know
from the inquiry data.

James

===== drivers/scsi/scsi_transport_spi.c 1.9 vs edited =====
--- 1.9/drivers/scsi/scsi_transport_spi.c	Thu Apr  8 08:39:09 2004
+++ edited/drivers/scsi/scsi_transport_spi.c	Thu Apr  8 12:35:07 2004
@@ -490,7 +490,7 @@
 	}
 
 	/* test width */
-	if (i->f->set_width) {
+	if (i->f->set_width && sdev->wdtr) {
 		i->f->set_width(sdev, 1);
 
 		if (!spi_dv_device_compare_inquiry(sreq, buffer,
@@ -502,6 +502,10 @@
 	}
 
 	if (!i->f->set_period)
+		return;
+
+	/* device can't handle synchronous */
+	if(!sdev->ppr && !sdev->sdtr)
 		return;
 
 	/* now set up to the maximum */