Re: Why is CONFIG_SCSI_QLA2X_X always enabled?

Re: Why is CONFIG_SCSI_QLA2X_X always enabled?

[Randy.Dunlap]

On Thu, 22 Apr 2004 16:48:47 +0100 Kieran wrote:

| This has been bugging me for a while.. on pretty much all 2.6 kernel 
| configs I've done, the .config has had CONFIG_SCSI_QLA2XXX=y in it, 
| regardless of whether or not I have any other SCSI stuff compiled in. Is 
| there a reason for this, or is it a bug?

A nuisance or annoyance perhaps.  Here's a patch for it.


// linux-266-rc2
// Make SCSI_QLA2XXX config option changeable/selectable

diffstat:=
 drivers/scsi/qla2xxx/Kconfig |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)


diff -Naurp ./drivers/scsi/qla2xxx/Kconfig~scsi_qla2 ./drivers/scsi/qla2xxx/Kconfig
--- ./drivers/scsi/qla2xxx/Kconfig~scsi_qla2	2004-04-20 15:54:24.000000000 -0700
+++ ./drivers/scsi/qla2xxx/Kconfig	2004-04-22 09:39:03.000000000 -0700
@@ -1,6 +1,5 @@
 config SCSI_QLA2XXX
-	tristate
-	default (SCSI && PCI)
+	tristate "Configure QLogic 21xx/22xx/23xx/63xx host adapters"
 	depends on SCSI && PCI
 
 config SCSI_QLA21XX

Re: Why is CONFIG_SCSI_QLA2X_X always enabled?

[James Bottomley]

On Thu, 2004-04-22 at 12:28, Randy.Dunlap wrote:
> A nuisance or annoyance perhaps.  Here's a patch for it.

No, it's a variable used to determine whether the user should be asked
about qla2xxx or not.

The proposed patch is obviously not correct, because we don't want the
user to be asked about it.

A better fix might be to make the qla2xxx a menu dependent on SCSI &&
PCI

James

Re: Why is CONFIG_SCSI_QLA2X_X always enabled?

[Randy.Dunlap]

On 22 Apr 2004 12:39:34 -0400 James Bottomley wrote:

| On Thu, 2004-04-22 at 12:28, Randy.Dunlap wrote:
| > A nuisance or annoyance perhaps.  Here's a patch for it.
| 
| No, it's a variable used to determine whether the user should be asked
| about qla2xxx or not.

As it is, for some large %age of users (say 99% ?), those 6 qla drivers
show up in the config menu when they aren't needed or wanted.
They get in the way.

| The proposed patch is obviously not correct, because we don't want the
| user to be asked about it.

You want it to always be presented (if PCI && SCSI) ?
No, it should be a selectable option iff PCI && SCSI.

| A better fix might be to make the qla2xxx a menu dependent on SCSI &&
| PCI

It already does.  The problem is that is defaults to the value of
(SCSI && PCI) when a large number of people don't need that
default value.  IOW, it's a bad choice for a default value.

--
~Randy
"We have met the enemy and he is us."  -- Pogo (by Walt Kelly)

Re: Why is CONFIG_SCSI_QLA2X_X always enabled?

[James Bottomley]

On Thu, 2004-04-22 at 13:12, Randy.Dunlap wrote:
> As it is, for some large %age of users (say 99% ?), those 6 qla drivers
> show up in the config menu when they aren't needed or wanted.
> They get in the way.

So you want a "Do you want Qlogic drivers" question followed by the 6
drivers if Y?

I'm less enthused about that.  I know there's precedent for it in the
net drivers, but I've always thought it caused more confusion than it
removed.  Traditionally, in SCSI, we've always presented every possible
driver in our list.

I thought the initial complaint you were trying to fix was the "why does
this show up in my .config one"?

James

Re: Why is CONFIG_SCSI_QLA2X_X always enabled?

[Randy.Dunlap]

On 22 Apr 2004 13:28:46 -0400 James Bottomley wrote:

| On Thu, 2004-04-22 at 13:12, Randy.Dunlap wrote:
| > As it is, for some large %age of users (say 99% ?), those 6 qla drivers
| > show up in the config menu when they aren't needed or wanted.
| > They get in the way.
| 
| So you want a "Do you want Qlogic drivers" question followed by the 6
| drivers if Y?
| 
| I'm less enthused about that.  I know there's precedent for it in the
| net drivers, but I've always thought it caused more confusion than it
| removed.  Traditionally, in SCSI, we've always presented every possible
| driver in our list.
| 
| I thought the initial complaint you were trying to fix was the "why does
| this show up in my .config one"?

The initial complaint was in $SUBJECT:
.config file always contains CONFIG_SCSI_QLA2XXX=y

and that's not needed, but the Kconfig file as is causes that.
Then that causes the further noise.

--
~Randy

Re: Why is CONFIG_SCSI_QLA2X_X always enabled?

[Randy.Dunlap]

On Thu, 22 Apr 2004 11:15:52 -0700 Randy.Dunlap wrote:

| On 22 Apr 2004 13:28:46 -0400 James Bottomley wrote:
| 
| | On Thu, 2004-04-22 at 13:12, Randy.Dunlap wrote:
| | > As it is, for some large %age of users (say 99% ?), those 6 qla drivers
| | > show up in the config menu when they aren't needed or wanted.
| | > They get in the way.
| | 
| | So you want a "Do you want Qlogic drivers" question followed by the 6
| | drivers if Y?
| | 
| | I'm less enthused about that.  I know there's precedent for it in the
| | net drivers, but I've always thought it caused more confusion than it
| | removed.  Traditionally, in SCSI, we've always presented every possible
| | driver in our list.

BTW, thanks for clarifying that.  Now we (or I) know.

| | I thought the initial complaint you were trying to fix was the "why does
| | this show up in my .config one"?
| 
| The initial complaint was in $SUBJECT:
| .config file always contains CONFIG_SCSI_QLA2XXX=y

which isn't a problem by itself, as you suggest (maybe?).

| and that's not needed, but the Kconfig file as is causes that.
| Then that causes the further noise.

--
~Randy

Re: Why is CONFIG_SCSI_QLA2X_X always enabled?

[James Bottomley]

On Thu, 2004-04-22 at 14:37, Randy.Dunlap wrote:
> which isn't a problem by itself, as you suggest (maybe?).

Yes, it was a harmless evolutionary addition to save having a depends
SCSI && PCI on every config option in the qla2xxx/Kconfig.

However, I believe in the Kconfig language there is a way of only
sourcing the qla2xxx/Kconfig if SCSI && PCI or of making it a menu
dependent on SCSI && PCI, so the variable could be eliminated nicely
that way.

James

Re: Why is CONFIG_SCSI_QLA2X_X always enabled?

[Roman Zippel]

Hi,

On 22 Apr 2004, James Bottomley wrote:

> On Thu, 2004-04-22 at 14:37, Randy.Dunlap wrote:
> > which isn't a problem by itself, as you suggest (maybe?).
>
> Yes, it was a harmless evolutionary addition to save having a depends
> SCSI && PCI on every config option in the qla2xxx/Kconfig.

Use "if SCSI && PCI" ... "endif" instead.

bye, Roman