From: James Bottomley <James.Bottomley@steeleye.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@osdl.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Jens Axboe <axboe@suse.de>
Subject: Re: [TRIVIAL] [TRIVIAL 2.6] drivers_scsi_gvp11.c: kill duplicate #include
Date: 20 May 2004 07:42:27 -0500 [thread overview]
Message-ID: <1085056948.2032.4.camel@mulgrave> (raw)
In-Reply-To: <1085035526.24935.140.camel@bach>
On Thu, 2004-05-20 at 02:07, Rusty Russell wrote:
> #define HOSTS_C
>
> -#include "gvp11.h"
> -
> static Scsi_Host_Template driver_template = {
> .proc_name = "GVP11",
> .name = "GVP Series II SCSI",
This is definitely wrong. I don't agree with the usage, but gvp11.h is
designed to be included twice. The define of HOST_C above alters the
behaviour of the second include.
If you'd like to fix it correctly....
James
prev parent reply other threads:[~2004-05-20 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-20 7:07 [TRIVIAL] [TRIVIAL 2.6] drivers_scsi_gvp11.c: kill duplicate #include Rusty Russell
2004-05-20 12:42 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1085056948.2032.4.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox