* [TRIVIAL] [TRIVIAL 2.6] drivers_scsi_gvp11.c: kill duplicate #include
@ 2004-05-20 7:07 Rusty Russell
2004-05-20 12:42 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: Rusty Russell @ 2004-05-20 7:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-scsi, axboe
From: a.othieno@bluewin.ch (Arthur Othieno)
---
Hi,
>From scripts/checkincludes.pl:
./drivers/scsi/gvp11.c: gvp11.h is included more than once.
Output from `grep' shows:
$ grep -n gvp11.h drivers/scsi/gvp11.c
21:#include "gvp11.h"
355:#include "gvp11.h"
Against 2.6.5. Thanks.
--- trivial-2.6.6-bk6/drivers/scsi/gvp11.c.orig 2004-05-20 15:59:33.000000000 +1000
+++ trivial-2.6.6-bk6/drivers/scsi/gvp11.c 2004-05-20 15:59:33.000000000 +1000
@@ -352,8 +352,6 @@
#define HOSTS_C
-#include "gvp11.h"
-
static Scsi_Host_Template driver_template = {
.proc_name = "GVP11",
.name = "GVP Series II SCSI",
--
What is this? http://www.kernel.org/pub/linux/kernel/people/rusty/trivial/
Don't blame me: the Monkey is driving
File: a.othieno@bluewin.ch (Arthur Othieno): [TRIVIAL 2.6] drivers_scsi_gvp11.c: kill duplicate #include
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [TRIVIAL] [TRIVIAL 2.6] drivers_scsi_gvp11.c: kill duplicate #include
2004-05-20 7:07 [TRIVIAL] [TRIVIAL 2.6] drivers_scsi_gvp11.c: kill duplicate #include Rusty Russell
@ 2004-05-20 12:42 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2004-05-20 12:42 UTC (permalink / raw)
To: Rusty Russell; +Cc: Andrew Morton, SCSI Mailing List, Jens Axboe
On Thu, 2004-05-20 at 02:07, Rusty Russell wrote:
> #define HOSTS_C
>
> -#include "gvp11.h"
> -
> static Scsi_Host_Template driver_template = {
> .proc_name = "GVP11",
> .name = "GVP Series II SCSI",
This is definitely wrong. I don't agree with the usage, but gvp11.h is
designed to be included twice. The define of HOST_C above alters the
behaviour of the second include.
If you'd like to fix it correctly....
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-05-20 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-20 7:07 [TRIVIAL] [TRIVIAL 2.6] drivers_scsi_gvp11.c: kill duplicate #include Rusty Russell
2004-05-20 12:42 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox