public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjanv@redhat.com>
To: "Infante, Jon" <Jon.Infante@Emulex.Com>
Cc: 'Christoph Hellwig' <hch@infradead.org>,
	"Smart, James" <James.Smart@Emulex.Com>,
	"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Subject: Re: DPC vs tasklet
Date: Thu, 20 May 2004 19:20:16 +0200	[thread overview]
Message-ID: <1085073616.2784.14.camel@laptop.fenrus.com> (raw)
In-Reply-To: <8D43EFD7CCBDB24980134BE078C227E704E37AEB@xcm.emulex.com>

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

On Thu, 2004-05-20 at 18:52, Infante, Jon wrote:
> Christoph,
> 
> I was going to take your advice:
> "usage of tasklet itself is questionable, you probably want a kernel-thread"

well there's a few angles here:
1) For IO completion (eg the common, fastpath case), you don't want to
use a tasklet OR kernel-thread, just do the completion right there and
then in the ISR, since the scsi layer completion handler you call will
queue it for real work, the final completion, by the scsi softirq
already.

2) For management work, I can see the point of doing it in a
kernel-thread, since it's 1) rare (eg slowpath) 2) complex 3) code that
might want long-ish delays or allocate memory, neither of which you want
in irq context.




[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2004-05-20 17:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-20 16:52 DPC vs tasklet Infante, Jon
2004-05-20 17:03 ` 'Christoph Hellwig'
2004-05-20 17:08 ` Jeff Garzik
2004-05-21  0:36   ` Bryan Henderson
2004-05-21  0:39     ` Matthew Wilcox
2004-05-21  7:46     ` Arjan van de Ven
2004-05-20 17:20 ` Arjan van de Ven [this message]
2004-05-20 17:57   ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2004-05-20 18:14 Infante, Jon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1085073616.2784.14.camel@laptop.fenrus.com \
    --to=arjanv@redhat.com \
    --cc=James.Smart@Emulex.Com \
    --cc=Jon.Infante@Emulex.Com \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox