Re: [PATCH] sdd scsi-ml event wq

[Arjan van de Ven <arjanv@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

On Fri, 2004-05-28 at 09:59, Mike Christie wrote:
> The attached patch just adds a scsi-ml work queue to handle all
> events. It also converts the transport_scsi_fc class to use it,
> so drivers using that class do not have to worry about calling
> the event functions from a process context.

question: it seems you allow only a limited number of outstanding
events, fair enough. However, how are users of this API supposed to
handle failure? I see you pass the error nicely all the way down, yet I
don't quite understand how a driver (the consumer of the API) is
supposed to handle failure. Queue the event itself? Sounds ugly/wrong to
me. I'm just wondering if the cleanup you propose doesn't just mean that
the uglyness gets pushed to correct users of the API.. which isn't quite
a nett win (under the assumption that there are more than one users of a
subsystem function)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]