Re: sg driver and Fedora Core 2

James Bottomley
2004-05-29T16:07:27Z

On Sat, 2004-05-29 at 10:57, Alan Cox wrote:
> On Sat, May 29, 2004 at 10:55:24AM -0500, James Bottomley wrote:
> > > This is an error. Linus has also vetoed this change. Consider the
> > > Fedora kernel wrong on this point. It isnt however your SG_IO issue I think
> >
> > I don't necessarily regard this as an error: single attachment of ULDs
> > would be very helpful. However, since the mechanics of implementing
>
> Its most definitely problematic - it breaks a ton of existing tools, and
> it also doesn't do what you think. Try this for size
>
> insmod scsidriver
> open /dev/sg0 (a hard disk)
> insmod sd

Refuse the insertion or do not attach, I suppose. It would be the app's
fault for not managing the interface correctly.

> Apps should migrate to the new facilities when possible but its definitely
> not a good idea to make this change

Yes, that's why a change like this appeals.

However, as I said, I'm aware it's problematic which is why I'm not
about to make any change like it at this point. But, if fedora can
demonstrate that it can be made to work sanely and easily, that would be
a very powerful argument for inclusion.

James