Re: sense visible despite ide-floppy in 2.6 maybe

[Pat LaVarre <p.lavarre@ieee.org>]

> Also something's broken (far far outside of the kernel) in plscsi.  I
> found success only by patching the trivial sgio.c that I posted in this
> thread, as shown below.

Ah. That is, despite the patch inserting idefloppy_blockpc_cmd,

ioctl(fd, SG_GET_VERSION_NUM, &vn) returns negative.

Pat LaVarre

P.S. More specifically,

plscsi, with perhaps excessively paranoid automagic, therefore chose not
to try 2.4 style ioctl SG_IO, complaining:

// sgioOpen.ioctl: Invalid argument
// plscsi.sclOpenNext: "/dev/hdd" not opened

By contrast, my back-of-the-envelope sgio.c was quietly stepping past
this trouble without complaint, in fact requiring vn at or beyond 30,000
only from devices that do support ioctl fd SG_GET_VERSION &vn.  The
trivial patch to get that fragment of code to behave as sensitively as
plscsi is of course:

--- sgio.was.c	2004-06-08 09:33:33.000000000 -0600
+++ sgio.c	2004-06-09 12:43:16.899046392 -0600
@@ -61,12 +61,15 @@ int main(int argc, char * argv[])
 	--argc; ++argv;
 	for (ix = 0; ix < argc; ++ix)
 	{
-		int fd = open(argv[ix], O_NONBLOCK|O_RDWR);
+		int fd = open(argv[ix], O_NONBLOCK);
 		if (fd < 0) {
 			perror("open");
 		} else {
 			int vn = 0;
-			if (0 <= ioctl(fd, SG_GET_VERSION_NUM, &vn)) {
+			if (ioctl(fd, SG_GET_VERSION_NUM, &vn) < 0) {
+				perror("ioctl SG_GET_VERSION_NUM");
+				; /* fallthru to talk anyhow */
+			} else {
 				if (vn < 30000) {
 					perror("ioctl SG_GET_VERSION_NUM");
 					continue;