From: Arjan van de Ven <arjanv@redhat.com>
To: "Smart, James" <James.Smart@Emulex.Com>
Cc: 'Christoph Hellwig' <hch@infradead.org>, linux-scsi@vger.kernel.org
Subject: RE: [PATCH] dead code and missing statics in lpfc
Date: Thu, 10 Jun 2004 16:43:52 +0200 [thread overview]
Message-ID: <1086878631.2733.13.camel@laptop.fenrus.com> (raw)
In-Reply-To: <3356669BBE90C448AD4645C843E2BF28034F9495@xbl.ma.emulex.com>
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
>
> Many would consider including this content, for no
> "standard" purpose, is another way to add crud to the driver. Making
> symbols available was a means to avoiding this latter issue.
a separate .c file that conditionally compiles into the driver is in my
opinion far less "crud" than blind hooks. The former allows for a
cleaner implementation I'm sure, AND has the benefit of being able to
see what is being done, so that any restructuring can 1) take it into
account and 2) fix it up on the go.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-06-10 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-10 14:33 [PATCH] dead code and missing statics in lpfc Smart, James
2004-06-10 14:43 ` Arjan van de Ven [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-06-10 13:24 Smart, James
2004-06-10 13:36 ` Arjan van de Ven
2004-06-09 11:08 Smart, James
2004-06-10 11:17 ` 'Christoph Hellwig'
2004-06-08 14:45 Smart, James
2004-06-09 8:55 ` 'Christoph Hellwig'
2004-05-31 10:04 Christoph Hellwig
2004-06-06 8:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086878631.2733.13.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=James.Smart@Emulex.Com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox