From: James Bottomley <James.Bottomley@steeleye.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH RFC 1/3] add fc transport events
Date: 12 Jun 2004 23:41:10 -0400 [thread overview]
Message-ID: <1087088793.1730.19.camel@mulgrave> (raw)
In-Reply-To: <40B597F5.2030501@cs.wisc.edu>
On Thu, 2004-05-27 at 03:25, Mike Christie wrote:
> 01-add-host-transport-classdev.patch - adds the transport class_device to
> the scsi_host structure.
I've been thinking about this quite a bit, and I like the general idea,
I just have a quibble with the implementation.
The main problem is the adding of a kobject to complement your host
transport class (and the device transport class). I don't think we need
to do this since, like the transport classes fall into either host or
device objects, so the events are similarly divided; thus, we should be
able to trigger the hotplug events through the host or device kobject
(that come with the embedded struct device) rather than adding another
kobject for the purpose.
What would be the disadvantage of doing what you propose this way
instead of using a separate kobject?
James
next prev parent reply other threads:[~2004-06-13 3:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-27 7:25 [PATCH RFC 1/3] add fc transport events Mike Christie
2004-06-13 3:41 ` James Bottomley [this message]
2004-06-13 20:44 ` Mike Christie
2004-06-13 21:23 ` Mike Christie
2004-06-13 22:46 ` James Bottomley
2004-06-13 23:17 ` Mike Christie
2004-06-14 2:15 ` Douglas Gilbert
2004-06-14 14:28 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087088793.1730.19.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox