Re: [PATCH RFC 1/3] add fc transport events

James Bottomley
2004-06-13T03:41:21Z

On Thu, 2004-05-27 at 03:25, Mike Christie wrote:
> 01-add-host-transport-classdev.patch - adds the transport class_device to
> the scsi_host structure.

I've been thinking about this quite a bit, and I like the general idea,
I just have a quibble with the implementation.

The main problem is the adding of a kobject to complement your host
transport class (and the device transport class). I don't think we need
to do this since, like the transport classes fall into either host or
device objects, so the events are similarly divided; thus, we should be
able to trigger the hotplug events through the host or device kobject
(that come with the embedded struct device) rather than adding another
kobject for the purpose.

What would be the disadvantage of doing what you propose this way
instead of using a separate kobject?

James