Re: Patch: s390 root on scsi disc

Re: Patch: s390 root on scsi disc

[Christoph Hellwig]

--- zfcp_aux.c.orig	2004-06-19 16:01:25.000000000 +0000
+++ zfcp_aux.c	2004-06-19 16:00:01.000000000 +0000
@@ -146,6 +146,17 @@
 module_param(flags_dump, uint, 0);
 #endif
 
+#ifndef MODULE
+/* remember kernel boot time parameter */
+static int __init zfcp_device(char *str)
+{
+	device = str;
+	return 1;
+}
+
+__setup("zfcpdevice=", zfcp_device);
+#endif

please use module_param instead.  still wondering why zfcp needs paramters
anyway..

Re: Patch: s390 root on scsi disc

[Christoph Hellwig]

On Sat, Jun 19, 2004 at 04:39:00PM +0000, Stefan Völkel wrote:
> > 
> > please use module_param instead.  still wondering why zfcp needs paramters
> > anyway..
> 
> Well, my problem was that passing device=foo at boot time (zfcp compiled
> into the kernel) resulted in device beeing empty. device is
> 
>         module_param(device, charp, 0);
>         MODULE_PARM_DESC(device, "specify initial device");

You need to pass zfcp.device=foo
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch: s390 root on scsi disc

[Stefan Völkel]

[-- Attachment #1.1: Type: text/plain, Size: 824 bytes --]

Hi,

the attached patch adds the ability to pass an initial zfcp scsi device
to the kernel. This enables us to have / on a scsi disc.

This is no "scsi only system" patch as you still need a small minidisk
that contains the kernel. Our typical setup looks like this:

        /	/dev/sda1
        /boot	/dev/dasda1
        
With this patch we are able to preserve our rare DASD space by having
most of the data on a cheap scsi disc in our JBOD.

regards
	Stefan
-- 
Stefan Völkel                            stefan.voelkel@millenux.com
Millenux GmbH                              mobile: +49.170.79177.17
Lilienthalstraße 2                          phone: +49.711.88770.300
70825 Stuttgart-Korntal                       fax: +49.711.88770.349
     -= linux without limits -=- http://linux.zSeries.org/ =-

[-- Attachment #1.2: zfcp_root.diff --]
[-- Type: text/x-patch, Size: 583 bytes --]

--- zfcp_aux.c.orig	2004-06-19 16:01:25.000000000 +0000
+++ zfcp_aux.c	2004-06-19 16:00:01.000000000 +0000
@@ -146,6 +146,17 @@
 module_param(flags_dump, uint, 0);
 #endif
 
+#ifndef MODULE
+/* remember kernel boot time parameter */
+static int __init zfcp_device(char *str)
+{
+	device = str;
+	return 1;
+}
+
+__setup("zfcpdevice=", zfcp_device);
+#endif
+
 /****************************************************************/
 /************** Functions without logging ***********************/
 /****************************************************************/

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Patch: s390 root on scsi disc

[Stefan Völkel]

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

On Sat, 2004-06-19 at 14:27, Christoph Hellwig wrote:
> --- zfcp_aux.c.orig	2004-06-19 16:01:25.000000000 +0000
> +++ zfcp_aux.c	2004-06-19 16:00:01.000000000 +0000
> @@ -146,6 +146,17 @@
>  module_param(flags_dump, uint, 0);
>  #endif
>  
> +#ifndef MODULE
> +/* remember kernel boot time parameter */
> +static int __init zfcp_device(char *str)
> +{
> +	device = str;
> +	return 1;
> +}
> +
> +__setup("zfcpdevice=", zfcp_device);
> +#endif
> 
> please use module_param instead.  still wondering why zfcp needs paramters
> anyway..

Well, my problem was that passing device=foo at boot time (zfcp compiled
into the kernel) resulted in device beeing empty. device is

        module_param(device, charp, 0);
        MODULE_PARM_DESC(device, "specify initial device");

regards
	Stefan
-- 
Stefan Völkel                            stefan.voelkel@millenux.com
Millenux GmbH                              mobile: +49.170.79177.17
Lilienthalstraße 2                          phone: +49.711.88770.300
70825 Stuttgart-Korntal                       fax: +49.711.88770.349
     -= linux without limits -=- http://linux.zSeries.org/ =-

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]