Re: Patch: s390 root on scsi disc

["Stefan Völkel" <stefan.voelkel@millenux.com>]

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

On Sat, 2004-06-19 at 14:27, Christoph Hellwig wrote:
> --- zfcp_aux.c.orig	2004-06-19 16:01:25.000000000 +0000
> +++ zfcp_aux.c	2004-06-19 16:00:01.000000000 +0000
> @@ -146,6 +146,17 @@
>  module_param(flags_dump, uint, 0);
>  #endif
>  
> +#ifndef MODULE
> +/* remember kernel boot time parameter */
> +static int __init zfcp_device(char *str)
> +{
> +	device = str;
> +	return 1;
> +}
> +
> +__setup("zfcpdevice=", zfcp_device);
> +#endif
> 
> please use module_param instead.  still wondering why zfcp needs paramters
> anyway..

Well, my problem was that passing device=foo at boot time (zfcp compiled
into the kernel) resulted in device beeing empty. device is

        module_param(device, charp, 0);
        MODULE_PARM_DESC(device, "specify initial device");

regards
	Stefan
-- 
Stefan Völkel                            stefan.voelkel@millenux.com
Millenux GmbH                              mobile: +49.170.79177.17
Lilienthalstraße 2                          phone: +49.711.88770.300
70825 Stuttgart-Korntal                       fax: +49.711.88770.349
     -= linux without limits -=- http://linux.zSeries.org/ =-

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]