From: James Bottomley <James.Bottomley@steeleye.com>
To: "Justin T. Gibbs" <gibbs@scsiguy.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Flexible timout intfrastructure take II
Date: 21 Jun 2004 13:11:10 -0500 [thread overview]
Message-ID: <1087841470.1797.71.camel@mulgrave> (raw)
In-Reply-To: <380DAEE648059C0AEE63E91D@aslan.scsiguy.com>
On Mon, 2004-06-21 at 12:24, Justin T. Gibbs wrote:
> You also need an:
>
> EH_NOT_FOUND: The HBA knows nothing about this command and
> has probably already completed it, but has no
> state to confirm this.
>
> or do you propose that the drivers just blindly return EH_HANDLED?
>
> Since scsi_done() has no return value, the LLD cannot know if the
> attempted completion was ignored due to losing the race with the timer.
> So it cannot keep state to ensure that it provides the correct response
> (EH_HANDLED) in this case.
How is this case different from EH_HANDLED? If the command has been
completed after the timer fired then it still needs to be completed when
the driver is notified of the timeout.
James
next prev parent reply other threads:[~2004-06-21 18:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-16 21:37 [PATCH] Flexible timout intfrastructure take II James Bottomley
2004-06-16 22:15 ` Luben Tuikov
2004-06-17 21:52 ` Mike Anderson
2004-06-21 17:24 ` Justin T. Gibbs
2004-06-21 18:11 ` James Bottomley [this message]
2004-06-21 19:08 ` Justin T. Gibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087841470.1797.71.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=gibbs@scsiguy.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox