linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* patch for scsi_devinfo.c
@ 2004-06-21 20:07 Dupuis, Chad
  2004-06-21 20:15 ` James Bottomley
  0 siblings, 1 reply; 4+ messages in thread
From: Dupuis, Chad @ 2004-06-21 20:07 UTC (permalink / raw)
  To: linux-scsi

The entries for HP and Compaq HSV110 are incorrect.  The HSV110
controllers report themselves as SCSI 2 devices and therefore need the
BLIST_LARGELUN flag to see LUNs passed 7.

----------------------------------------
--- scsi_devinfo.c      2004-06-21 16:06:14.000000000 -0400
+++ scsi_devinfo.c.new  2004-06-21 16:01:43.000000000 -0400
@@ -126,7 +126,7 @@ static struct {
        {"COMPAQ", "CR3500", NULL, BLIST_FORCELUN},
        {"COMPAQ", "MSA1000", NULL, BLIST_SPARSELUN |
BLIST_NOSTARTONADD},
        {"COMPAQ", "MSA1000 VOLUME", NULL, BLIST_SPARSELUN |
BLIST_NOSTARTONADD},
-       {"COMPAQ", "HSV110", NULL, BLIST_SPARSELUN |
BLIST_NOSTARTONADD},
+       {"COMPAQ", "HSV110", NULL, BLIST_SPARSELUN | BLIST_LARGELUN |
BLIST_NOSTARTONADD},
        {"DDN", "SAN DataDirector", "*", BLIST_SPARSELUN},
        {"DEC", "HSG80", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
        {"DELL", "PV660F", NULL, BLIST_SPARSELUN},
@@ -147,7 +147,7 @@ static struct {
        {"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN},
/* HP VA7400 */
        {"HP", "OPEN-", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, /* HP XP
Arrays */
        {"HP", "NetRAID-4M", NULL, BLIST_FORCELUN},
-       {"HP", "HSV100", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
+       {"HP", "HSV100", NULL, BLIST_SPARSELUN | BLIST_LARGELUN |
BLIST_NOSTARTONADD},
        {"HP", "C1557A", NULL, BLIST_FORCELUN},
        {"IBM", "AuSaV1S2", NULL, BLIST_FORCELUN},
        {"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN |
BLIST_LARGELUN},

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: patch for scsi_devinfo.c
  2004-06-21 20:07 patch for scsi_devinfo.c Dupuis, Chad
@ 2004-06-21 20:15 ` James Bottomley
  0 siblings, 0 replies; 4+ messages in thread
From: James Bottomley @ 2004-06-21 20:15 UTC (permalink / raw)
  To: Dupuis, Chad; +Cc: SCSI Mailing List

On Mon, 2004-06-21 at 15:07, Dupuis, Chad wrote:
> The entries for HP and Compaq HSV110 are incorrect.  The HSV110
> controllers report themselves as SCSI 2 devices and therefore need the
> BLIST_LARGELUN flag to see LUNs passed 7.

Do they also respond to REPORT LUNS?  In which case we could flag them
as that instead of BLIST_SPARSELUN|BLIST_LARGELUN

James



^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: patch for scsi_devinfo.c
@ 2004-06-21 20:16 Dupuis, Chad
  2004-06-21 20:23 ` James Bottomley
  0 siblings, 1 reply; 4+ messages in thread
From: Dupuis, Chad @ 2004-06-21 20:16 UTC (permalink / raw)
  To: James Bottomley; +Cc: SCSI Mailing List

It does respond to report LUN.

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@steeleye.com] 
Sent: Monday, June 21, 2004 4:15 PM
To: Dupuis, Chad
Cc: SCSI Mailing List
Subject: Re: patch for scsi_devinfo.c


On Mon, 2004-06-21 at 15:07, Dupuis, Chad wrote:
> The entries for HP and Compaq HSV110 are incorrect.  The HSV110 
> controllers report themselves as SCSI 2 devices and therefore need the

> BLIST_LARGELUN flag to see LUNs passed 7.

Do they also respond to REPORT LUNS?  In which case we could flag them
as that instead of BLIST_SPARSELUN|BLIST_LARGELUN

James



^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: patch for scsi_devinfo.c
  2004-06-21 20:16 Dupuis, Chad
@ 2004-06-21 20:23 ` James Bottomley
  0 siblings, 0 replies; 4+ messages in thread
From: James Bottomley @ 2004-06-21 20:23 UTC (permalink / raw)
  To: Dupuis, Chad; +Cc: SCSI Mailing List

On Mon, 2004-06-21 at 15:16, Dupuis, Chad wrote:
> It does respond to report LUN.

OK, so this should be the patch.  Could you make sure it actually does
work?

Thanks,

James

===== drivers/scsi/scsi_devinfo.c 1.21 vs edited =====
--- 1.21/drivers/scsi/scsi_devinfo.c	2004-06-19 09:48:22 -05:00
+++ edited/drivers/scsi/scsi_devinfo.c	2004-06-21 15:22:17 -05:00
@@ -129,7 +129,7 @@
 	{"COMPAQ", "CR3500", NULL, BLIST_FORCELUN},
 	{"COMPAQ", "MSA1000", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
 	{"COMPAQ", "MSA1000 VOLUME", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
-	{"COMPAQ", "HSV110", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
+	{"COMPAQ", "HSV110", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
 	{"DDN", "SAN DataDirector", "*", BLIST_SPARSELUN},
 	{"DEC", "HSG80", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
 	{"DELL", "PV660F", NULL, BLIST_SPARSELUN},
@@ -151,7 +151,7 @@
 	{"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN},	/* HP VA7400 */
 	{"HP", "OPEN-", "*", BLIST_SPARSELUN | BLIST_LARGELUN}, /* HP XP Arrays */
 	{"HP", "NetRAID-4M", NULL, BLIST_FORCELUN},
-	{"HP", "HSV100", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
+	{"HP", "HSV100", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
 	{"HP", "C1557A", NULL, BLIST_FORCELUN},
 	{"IBM", "AuSaV1S2", NULL, BLIST_FORCELUN},
 	{"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN | BLIST_LARGELUN},


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2004-06-21 20:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-21 20:07 patch for scsi_devinfo.c Dupuis, Chad
2004-06-21 20:15 ` James Bottomley
  -- strict thread matches above, loose matches on Subject: below --
2004-06-21 20:16 Dupuis, Chad
2004-06-21 20:23 ` James Bottomley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).