From: Arjan van de Ven <arjanv@redhat.com>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@steeleye.com>
Subject: Re: PATCH [2/18] qla2xxx: Correct residual counts
Date: Tue, 22 Jun 2004 09:06:32 +0200 [thread overview]
Message-ID: <1087887992.2704.8.camel@laptop.fenrus.com> (raw)
In-Reply-To: <20040622054946.GA8392@linux.local.home>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
On Tue, 2004-06-22 at 07:49, Andrew Vasquez wrote:
> diff -Nru a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
> --- a/drivers/scsi/qla2xxx/qla_iocb.c 2004-06-21 15:36:37 -07:00
> +++ b/drivers/scsi/qla2xxx/qla_iocb.c 2004-06-21 15:36:37 -07:00
> @@ -43,7 +43,7 @@
> else if (cmd->sc_data_direction == DMA_FROM_DEVICE)
> cflags = CF_READ;
> else {
> - switch (cmd->data_cmnd[0]) {
> + switch (cmd->cmnd[0]) {
> case WRITE_6:
> case WRITE_10:
> case WRITE_12:
this sounds wrong. Is there any reason qlogic drivers can't use/trust
the midlayer instead of doing qla2x00_get_cmd_direction() to reverse
engineer to direction ??
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-06-22 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-22 5:49 PATCH [2/18] qla2xxx: Correct residual counts Andrew Vasquez
2004-06-22 7:06 ` Arjan van de Ven [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-06-22 14:17 Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087887992.2704.8.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=James.Bottomley@steeleye.com \
--cc=andrew.vasquez@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox