Re: [Patch 2.6] sd.c spinup messages

[James Bottomley <James.Bottomley@steeleye.com>]

On Wed, 2004-06-09 at 18:48, Chuck Ebbert wrote:
> -                               printk(KERN_NOTICE "%s: Spinning up disk...",
> +                               printk(KERN_NOTICE "%s: Spinning up disk...\n",
>                                        diskname);
>                                 cmd[0] = START_STOP;
>                                 cmd[1] = 1;     /* Return immediately */
> @@ -903,7 +906,6 @@ sd_spinup_disk(struct scsi_disk *sdkp, c
>                                 current->state = TASK_UNINTERRUPTIBLE;
>                                 time1 = schedule_timeout(time1);
>                         } while(time1);
> -                       printk(".");

What this basically does is remove the indication that the drive is
being spun up.  That's quite a significant user visible change from what
we do now.

Current behaviour is dictated by the fact that some of the drives
(particularly older ones) take ages to spin up.  Without the visual
indication that something is going on people tend to press the reset
button and report kernel errors.

Instead of making such a global change, how about making this a
non-default configurable option within sd.

James