From: James Bottomley <James.Bottomley@steeleye.com>
To: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: [PATCH] fix aic7xxx probing
Date: 24 Jun 2004 17:49:00 -0500 [thread overview]
Message-ID: <1088117341.2174.67.camel@mulgrave> (raw)
It looks like there's still a problem with the probing:
ahc_linux_pci_init() returns the number of boards attached
ahc_linux_eisa_init() returns 0 on success or error
The only reason the current code actually works on PCI seems to be that
it's already attached the devices by the time it returns what the
ahc_linux_detect() assumes to be a failure code.
James
===== drivers/scsi/aic7xxx/aic7xxx_osm.c 1.54 vs edited =====
--- 1.54/drivers/scsi/aic7xxx/aic7xxx_osm.c 2004-04-26 02:09:37 -04:00
+++ edited/drivers/scsi/aic7xxx/aic7xxx_osm.c 2004-06-24 18:39:54 -04:00
@@ -842,9 +842,7 @@
static int
ahc_linux_detect(Scsi_Host_Template *template)
{
- struct ahc_softc *ahc;
int found = 0;
- int eisa_err, pci_err;
#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
/*
@@ -892,13 +890,11 @@
*/
ahc_list_lockinit();
- pci_err = ahc_linux_pci_init();
- eisa_err = ahc_linux_eisa_init();
-
- if(pci_err && eisa_err)
- goto out;
-
-
+ found = ahc_linux_pci_init();
+ if (!ahc_linux_eisa_init())
+ found++;
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
/*
* Register with the SCSI layer all
* controllers we've found.
@@ -908,9 +904,7 @@
if (ahc_linux_register_host(ahc, template) == 0)
found++;
}
-out:
-#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
spin_lock_irq(&io_request_lock);
#endif
aic7xxx_detect_complete++;
===== drivers/scsi/aic7xxx/aic7xxx_osm.h 1.54 vs edited =====
--- 1.54/drivers/scsi/aic7xxx/aic7xxx_osm.h 2004-05-12 11:46:27 -04:00
+++ edited/drivers/scsi/aic7xxx/aic7xxx_osm.h 2004-06-24 18:41:49 -04:00
@@ -940,7 +940,7 @@
}
#else
static inline int ahc_linux_pci_init(void) {
- return -ENODEV;
+ return 0;
}
static inline void ahc_linux_pci_exit(void) {
}
next reply other threads:[~2004-06-24 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-24 22:49 James Bottomley [this message]
2004-06-25 4:56 ` [PATCH] fix aic7xxx probing Zwane Mwaikambo
2004-06-25 13:29 ` James Bottomley
2004-06-25 14:35 ` Zwane Mwaikambo
2004-06-25 14:52 ` James Bottomley
2004-06-25 15:09 ` Zwane Mwaikambo
2004-06-25 15:16 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088117341.2174.67.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox