[PATCH] Re: no set_current_state() before schedule_timeout() (OSST)

[Willem Riede <osst@riede.org>]

On 07/13/2004 01:40:54 PM, Nishanth Aravamudan wrote:
> Hi,
> 
> In continuing to replace, where appropriate, code with msleep() calls, I
> ran across the following file(s) / function(s), which do not invoke
> set_current_state() before schedule_timeout(), which causes the latter
> to return immediately:
> 
> drivers/scsi/osst.c::osst_reposition_and_retry()
> 
> If someone could tell me which state (TASK_INTERRUPTIBLE or
> TASK_UNINTERRUPTIBLE) is desired, I can fix this and perhaps replace the
> calls with msleep().

You're right, there is a set_current_state(TASK_INTERRUPTIBLE) missing.
I don't know why we would want to change to use msleep() though.
Below is the patch to add the missing statement.

James Bottomley, can you apply this patch?

Regards, Willem Riede.

Signed-off-by: Willem Riede <osst@riede.org>

--- linux-2.6.8-rc1/drivers/scsi/osst.c.orig	2004-07-13
18:59:16.026349000 -0400
+++ linux-2.6.8-rc1/drivers/scsi/osst.c	2004-07-13 19:01:58.040719208
-0400
@@ -1555,6 +1555,7 @@
 			debugging = 0;
 		}
 #endif
+		set_current_state(TASK_INTERRUPTIBLE);
 		schedule_timeout(HZ / 10);
 	}
 	printk(KERN_ERR "%s:E: Failed to find valid tape media\n", name);