public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* BK: scsi-misc cs inconsistencies?
@ 2004-07-14 10:24 Guennadi Liakhovetski
  2004-07-14 13:33 ` James Bottomley
  0 siblings, 1 reply; 3+ messages in thread
From: Guennadi Liakhovetski @ 2004-07-14 10:24 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-scsi

Hello

I've searched scsi-misc cs-entries on bk, and they don't seem to be quite 
consistent:

Linux kernel tree Search results for "tmscsim" in ChangeSet comments

Filename  Rev		Match

ChangeSet 1.1861	[PATCH] tmscsim: kernel bugzilla bug #2139 
ChangeSet 1.1760.31.6	[PATCH] kill obsolete typedefs and wrappers from tmscsim 
ChangeSet 1.1760.31.5	[PATCH] some tmscsim consolidation 
(6)
ChangeSet 1.1760.31.5	> I've looked through my old tmscsim patch queue and found this one: 
(7)
ChangeSet 1.1739.2.17	[PATCH] tmscsim: host_lock use in LLD 
(1)
ChangeSet 1.1739.2.17	While reviewing tmscsim, I noticed something, I didn't quite like / 
(2)
ChangeSet 1.1739.2.16	[PATCH] tmscsim: init / exit cleanup 
ChangeSet 1.1722.73.26	[PATCH] tmscsim: 64-bit cleanup 
(3)
ChangeSet 1.1722.73.26	tmscsim.c. 
(4)
ChangeSet 1.1722.73.5	[PATCH] tmscsim: Store pDCB in device->hostdata 
ChangeSet 1.1722.45.17	[PATCH] tmscsim: convert to slave_... 
ChangeSet 1.1722.45.15	[PATCH] tmscsim: remove DeviceCnt 
ChangeSet 1.1722.45.14	[PATCH] tmscsim: Update version after "new API" 
ChangeSet 1.1612.6.20	[PATCH] tmscsim: trivial updates 
ChangeSet 1.1612.6.14	[PATCH] tmscsim: remove legacy and void code 
ChangeSet 1.1612.6.13	tmscsim: remove procfs write support from tmscsim 
ChangeSet 1.1612.6.11	[PATCH] tmscsim: no internal queue 
ChangeSet 1.1612.6.9	[PATCH] tmscsim: 64-bit cleanup 
(5)
ChangeSet 1.1371.1.378	[PATCH] Fix tmscsim on amd64 
ChangeSet 1.1371.94.3	SCSI: Fix tmscsim driver 
ChangeSet 1.1046.250.59	PCI: remove pci_present() from drivers/scsi/tmscsim.c

Here, (6), (7); (1), (2); and (3), (4) have the same cs-number, (3) and 
(5) have the same description. Is it a problem with the BK itself, or with 
the way these entries have been committed? In the former case I can 
forward this to Larry / BitMover support / whatever. Or is just my 
understanding wrong and all those fields do not have to be unique?...

Thanks
Guennadi
---
Guennadi Liakhovetski


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: BK: scsi-misc cs inconsistencies?
  2004-07-14 10:24 BK: scsi-misc cs inconsistencies? Guennadi Liakhovetski
@ 2004-07-14 13:33 ` James Bottomley
  2004-07-14 19:28   ` Guennadi Liakhovetski
  0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2004-07-14 13:33 UTC (permalink / raw)
  To: Guennadi Liakhovetski; +Cc: SCSI Mailing List

On Wed, 2004-07-14 at 05:24, Guennadi Liakhovetski wrote:
> Hello
> 
> I've searched scsi-misc cs-entries on bk, and they don't seem to be quite 
> consistent:
> 
> Linux kernel tree Search results for "tmscsim" in ChangeSet comments

If you mean you searched through the bk commits list, then yes, this is
what you see since change sets can renumber as trees are combined.

James



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: BK: scsi-misc cs inconsistencies?
  2004-07-14 13:33 ` James Bottomley
@ 2004-07-14 19:28   ` Guennadi Liakhovetski
  0 siblings, 0 replies; 3+ messages in thread
From: Guennadi Liakhovetski @ 2004-07-14 19:28 UTC (permalink / raw)
  To: James Bottomley; +Cc: SCSI Mailing List

On Wed, 14 Jul 2004, James Bottomley wrote:

> On Wed, 2004-07-14 at 05:24, Guennadi Liakhovetski wrote:
>> Hello
>>
>> I've searched scsi-misc cs-entries on bk, and they don't seem to be quite
>> consistent:
>>
>> Linux kernel tree Search results for "tmscsim" in ChangeSet comments
>
> If you mean you searched through the bk commits list, then yes, this is
> what you see since change sets can renumber as trees are combined.

Well, I just went to http://linux-scsi.bkbits.net:8080/scsi-misc-2.6 
entered a search term and pressed SEARCH, thus searching in changeset 
comments. If you mean, that 2 different changesets can appear in the 
resulting list with the same number, then this is useless, as only one of 
them can be viewed - links point to the same address. If on the other 
hand, this is the same patch, just occurring twice, well, that's just a 
bit confusing, but at least no information gets lost.

Thanks and sorry for OT.
Guennadi
---
Guennadi Liakhovetski


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-07-14 20:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-14 10:24 BK: scsi-misc cs inconsistencies? Guennadi Liakhovetski
2004-07-14 13:33 ` James Bottomley
2004-07-14 19:28   ` Guennadi Liakhovetski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox