From: James Bottomley <James.Bottomley@SteelEye.com>
To: James.Smart@Emulex.Com
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH] updated: suspending I/Os to a device
Date: 19 Aug 2004 13:42:47 -0400 [thread overview]
Message-ID: <1092937373.2378.697.camel@mulgrave> (raw)
In-Reply-To: <0B1E13B586976742A7599D71A6AC733C02D85A@xbl3.ma.emulex.com>
On Thu, 2004-08-19 at 13:24, James.Smart@Emulex.Com wrote:
> The one con:
> Depends on well-behaved LLDD's to not leave the device blocked indefinitely.
> But this is no different from scsi_block_requests().
But that's the big one.
A significant number of driver bugs have come to us from incorrect timer
handling (not understanding the difference between del_timer and
del_timer_sync being the biggest).
The whole reason for moving the code up into the mid-layer is to avoid
the LLD handling the timer.
After the rewrite to simplify the code, the added overhead of having the
mid-layer (and transport classes) do the timer is scarcely sevently
lines longer than the one you currently attach.
James
next prev parent reply other threads:[~2004-08-19 17:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-19 17:24 [PATCH] updated: suspending I/Os to a device James.Smart
2004-08-19 17:42 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-01 19:30 James.Smart
2004-09-01 19:44 ` Christoph Hellwig
2004-08-20 13:24 James.Smart
2004-08-19 18:24 James.Smart
2004-08-20 8:55 ` Mike Anderson
2004-08-20 13:48 ` Luben Tuikov
2004-08-10 21:00 James.Smart
2004-08-11 22:11 ` Christoph Hellwig
2004-08-10 20:35 James.Smart
2004-08-10 20:50 ` Christoph Hellwig
2004-08-17 4:39 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092937373.2378.697.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=James.Smart@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox