* [PATCH] fix for Domain Validation hang on some devices with sym_2 driver
@ 2004-08-20 2:55 James Bottomley
2004-08-20 14:55 ` [PATCH] fix for Domain Validation hang on some devices with sym_2driver Kai OM
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2004-08-20 2:55 UTC (permalink / raw)
To: willy; +Cc: SCSI Mailing List
There's a bad hang where the driver locks the system solid trying to do
domain validation with certain devices. The one I've managed to
reproduce it with is a Quantum Atlas.
What happens is that setting the offset to zero is an async negotiation
message. However, the driver still seems to have DT set (which is
illegal). Most devices just reject this as stupid, but the Quantum
seems to try to obey it and hangs the bus.
The simple fix is to reset all PPR options when the offset is set to
zero.
James
===== drivers/scsi/sym53c8xx_2/sym_glue.c 1.44 vs edited =====
--- 1.44/drivers/scsi/sym53c8xx_2/sym_glue.c 2004-07-26 17:24:36 -04:00
+++ edited/drivers/scsi/sym53c8xx_2/sym_glue.c 2004-08-19 22:30:35 -04:00
@@ -2383,6 +2383,9 @@
struct sym_hcb *np = ((struct host_data *)sdev->host->hostdata)->ncb;
struct sym_tcb *tp = &np->target[sdev->id];
+ if (offset == 0)
+ tp->tinfo.goal.options = 0;
+
if (tp->tinfo.curr.options & PPR_OPT_DT) {
if (offset > np->maxoffs_dt)
offset = np->maxoffs_dt;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fix for Domain Validation hang on some devices with sym_2driver
2004-08-20 2:55 [PATCH] fix for Domain Validation hang on some devices with sym_2 driver James Bottomley
@ 2004-08-20 14:55 ` Kai OM
2004-08-20 16:34 ` Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: Kai OM @ 2004-08-20 14:55 UTC (permalink / raw)
To: James Bottomley, willy; +Cc: SCSI Mailing List
On 19 Aug 2004 22:55:57 -0400, "James Bottomley"
<James.Bottomley@SteelEye.com> said:
> There's a bad hang where the driver locks the system solid trying to do
> domain validation with certain devices. The one I've managed to
> reproduce it with is a Quantum Atlas.
>
> What happens is that setting the offset to zero is an async negotiation
> message. However, the driver still seems to have DT set (which is
> illegal). Most devices just reject this as stupid, but the Quantum
> seems to try to obey it and hangs the bus.
>
> The simple fix is to reset all PPR options when the offset is set to
> zero.
As they said in the '90s, "you da' man."
It works perfectly, so far as I can tell.
So, um, what I want to know is... why did the issue appear to go away
for some people if they switched controllers?
I don't know a terrible lot about SCSI devices, so maybe someone here
could tell me if there's a reason that would happen, or is this to be
expected?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix for Domain Validation hang on some devices with sym_2driver
2004-08-20 14:55 ` [PATCH] fix for Domain Validation hang on some devices with sym_2driver Kai OM
@ 2004-08-20 16:34 ` Matthew Wilcox
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2004-08-20 16:34 UTC (permalink / raw)
To: Kai OM; +Cc: James Bottomley, willy, SCSI Mailing List
On Fri, Aug 20, 2004 at 10:55:34AM -0400, Kai OM wrote:
> So, um, what I want to know is... why did the issue appear to go away
> for some people if they switched controllers?
Well, the 896 only does 80MB/s rather than 160MB/s, so it won't trigger
the bug where the 1010 will.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-08-20 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-20 2:55 [PATCH] fix for Domain Validation hang on some devices with sym_2 driver James Bottomley
2004-08-20 14:55 ` [PATCH] fix for Domain Validation hang on some devices with sym_2driver Kai OM
2004-08-20 16:34 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox