Re: [PATCH] add extra inquiry byte 56 data to struct scsi_device

[James Bottomley <James.Bottomley@SteelEye.com>]

On Fri, 2004-08-20 at 23:21, Jeff Garzik wrote:
> Do you forsee ever adding more feature bits like this?

Never say never, but the standard looks now to be fixed.  The only
waiting extension of SPI5 was fast-360, which doesn't look like being
realised.

> It seems to me that a more maintainable approach is to cache relevant 
> INQUIRY data in a buffer, and then create accessor macros for 
> programmers' use.
> 
> That way you don't have to keep adding members (really, mnemonics) to a 
> data structure, and associated initialization code, each time the 
> mid-layer or some low-level drivers want to test a new feature bit. 
> Initialization via memcpy is easy and automatic.

Only if someone else converts all the drivers...but yet, if more bits
come along, that's probably what we should do.

James