From: James Bottomley <James.Bottomley@SteelEye.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] tmscsim: INQUIRY always only untagged
Date: 05 Sep 2004 18:22:27 -0400 [thread overview]
Message-ID: <1094422949.10977.15.camel@mulgrave> (raw)
In-Reply-To: <20040905173134.A31521@infradead.org>
On Sun, 2004-09-05 at 12:31, Christoph Hellwig wrote:
> Umm yes. But lets get the driver no oops first and then move forward.
> There's still a lot of work to do on the driver.
Well, OK. I agree to putting a palliative fix in, since what I
suggested will probably take more thought, but I don't think this one is
actually it. Mixing tagged and untagged commands is illegal under the
SCSI spec. Simply untagging the INQUIRY command may work to fix this
particular bug, but I bet it will introduce others when a scsi utility
sends an INQUIRY down to an in-use device.
I think perhaps the correct palliative fix is simply to list this device
(whatever it is, it's not listed in the bug report) as BLIST_NOTQ, then
the problem won't arise (and of course, tmscsim would have actually to
use the mid-layer black list rather than its own much shorter internal
list).
James
next prev parent reply other threads:[~2004-09-05 22:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 22:41 [PATCH] tmscsim: INQUIRY always only untagged Guennadi Liakhovetski
2004-09-04 13:01 ` Christoph Hellwig
2004-09-04 22:26 ` Guennadi Liakhovetski
2004-09-04 22:38 ` Christoph Hellwig
2004-09-05 14:56 ` Guennadi Liakhovetski
2004-09-05 15:42 ` James Bottomley
2004-09-05 16:31 ` Christoph Hellwig
2004-09-05 20:19 ` Guennadi Liakhovetski
2004-09-06 14:34 ` James Bottomley
2004-09-05 22:22 ` James Bottomley [this message]
2004-09-06 8:50 ` Guennadi Liakhovetski
2004-09-06 9:47 ` Guennadi Liakhovetski
2004-09-06 10:01 ` Christoph Hellwig
2004-09-06 13:17 ` Guennadi Liakhovetski
2004-10-01 21:04 ` Guennadi Liakhovetski
2004-10-01 22:35 ` Christoph Hellwig
2004-10-01 22:46 ` Christoph Hellwig
2004-10-01 23:46 ` Guennadi Liakhovetski
2004-10-02 17:00 ` Guennadi Liakhovetski
2004-10-01 21:00 ` Guennadi Liakhovetski
2004-10-01 22:31 ` Christoph Hellwig
2004-10-01 23:44 ` Guennadi Liakhovetski
2004-09-15 5:30 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1094422949.10977.15.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=g.liakhovetski@gmx.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox