Re: SCSI QLA not working on latest *-mm SN2

Jeremy Higdon
2004-09-22T01:17:17Z

On Wed, Sep 22, 2004 at 01:02:11AM +0100, Matthew Wilcox wrote:
> On Tue, Sep 21, 2004 at 02:43:02PM -0700, Jeremy Higdon wrote:
> > That could be very painful.
> > On Irix, we actually had a separate spinunlock (io_spin_unlock) that
> > added the MIPS equivalent. I'm assuming we don't want to entertain
> > that here :-) (Though tell me if I'm wrong)
>
> That seems like a reasonable solution to me. Want to float it to Linus
> and see how he takes it?

First let's make sure that we like it best.

The other alternative is an explicit I/O barrier.

writel(high-water, request-in)
mmiob() /* memory-mapped I/O barrier */
spin_unlock(hostlock)

versus

writel(high-water, request-in)
spin_unlock_iob(hostlock)

I think I like the former better (even though we had the latter in Irix).
But I don't have a strong preference.

One of us will offer a patch.

jeremy