From: James Bottomley <James.Bottomley@SteelEye.com>
To: Masao Fukuchi <fukuchi.masao@jp.fujitsu.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC]transient transport error report for LLD timeout
Date: 27 Sep 2004 10:06:41 -0400 [thread overview]
Message-ID: <1096294008.1714.7.camel@mulgrave> (raw)
In-Reply-To: <200409232332.AA03619@fukuchi.jp.fujitsu.com>
On Thu, 2004-09-23 at 19:32, Masao Fukuchi wrote:
> Therefore, I newly prepared timer in block layer.
> When it detects timeout, it responds to upper(RAID/multipath) layer and
> upper layer begins retry operation using alt-disk/alt-path.
> Resource using in block and SCSI(LLD) layer is freed when it receives
> response from LLD(SCSI) layer.
I really don't think this is the correct thing to do. The block layer
has no idea what's actually happened to the command, but it's going to
complete it anyway. Depending on what goes on above, this may unpin the
user pages that the scsi_cmnd is still using. Also, the two timers
(scsi command timer and this new block layer timer are critically
coupled. Tune them wrongly and nasty things will happen).
The right thing to do is to see the no retry flag in error recovery and
complete the command when we see the host has relinquished it. Then go
on to do transport recovery with a new command.
James
prev parent reply other threads:[~2004-09-27 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 23:32 [RFC]transient transport error report for LLD timeout Masao Fukuchi
2004-09-26 0:28 ` Rik van Riel
2004-09-27 14:06 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096294008.1714.7.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=fukuchi.masao@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox