From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jeremy Higdon <jeremy@sgi.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
andrew.vasquez@qlogic.com
Subject: Re: [RFC PATCH 2.6.9-rc2] Add sysfs queue depth override to qla2xxx
Date: 28 Sep 2004 10:05:31 -0400 [thread overview]
Message-ID: <1096380337.1717.4.camel@mulgrave> (raw)
In-Reply-To: <20040928075407.GA190115@sgi.com>
On Tue, 2004-09-28 at 03:54, Jeremy Higdon wrote:
> On Sun, Sep 26, 2004 at 11:10:03PM -0700, Jeremy Higdon wrote:
> > This patch is to QLA2xxx version 8.00.00b15-k, and it allows users
> > to override the default driver queue depth for a target by making
> > the queue_depth sysfs attribute writeable.
> >
> > I based this on the code in the 53c700 driver.
> >
> > Andrew, please apply if it looks correct to you and James.
> >
> > Let me know if you'd like me to regenerate against a different qla2xxx
> > version.
> >
> > thanks
> >
> > Jeremy
>
> Found a bug in the patch. It returned an incorrect count if tagged_supported
> was not true.
I haven't had time to check yet, but I believe I remember queue depth
being also a parameter that has to be communicated to the card's
firmware for the sizing of an internal queue. Could you check ... and
if that is the case, we'll have to communicate this change to the card
as well.
James
next prev parent reply other threads:[~2004-09-28 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 6:10 [RFC PATCH 2.6.9-rc2] Add sysfs queue depth override to qla2xxx Jeremy Higdon
2004-09-27 6:25 ` Jeremy Higdon
2004-09-28 7:54 ` Jeremy Higdon
2004-09-28 14:05 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-28 16:52 Andrew Vasquez
2004-09-28 19:36 ` Jeremy Higdon
2004-09-28 19:53 ` James Bottomley
2004-09-28 20:12 ` Jens Axboe
2004-09-28 20:34 ` Andrew Vasquez
2004-09-29 6:21 ` Jens Axboe
2004-09-29 6:57 ` Jeremy Higdon
2004-09-29 6:56 ` Jens Axboe
2004-09-29 0:36 ` Jeremy Higdon
2004-09-29 16:41 ` Andrew Vasquez
2004-09-29 22:12 ` Jeremy Higdon
2004-09-28 16:54 Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096380337.1717.4.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=andrew.vasquez@qlogic.com \
--cc=jeremy@sgi.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).