From: James Bottomley <James.Bottomley@SteelEye.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Luben Tuikov <luben_tuikov@adaptec.com>,
SCSI development list <linux-scsi@vger.kernel.org>,
Mohammed Sameer <uniball@gmx.net>,
USB users list <linux-usb-users@lists.sourceforge.net>
Subject: Re: BUG: CD driver sends command during host removal
Date: 29 Sep 2004 15:50:54 -0400 [thread overview]
Message-ID: <1096487461.2028.134.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0409291452120.1700-100000@ida.rowland.org>
On Wed, 2004-09-29 at 15:01, Alan Stern wrote:
> Regardless of how descriptive the value is, the code in
> scsi_dispatch_cmd treats anything other than SCSI_MLQUEUE_DEVICE_BUSY
> as SCSI_MLQUEUE_HOST_BUSY. Will this matter?
Yes, you have to call cmd->done() having set the result field to
DID_NO_CONNECT; then return zero from queuecommand() indicating that
you're dealling with the command.
> It sounds like the two of you are in contradiction. Should the SCSI core
> deallocate in-flight commands without consulting the LLDD or shouldn't it?
Once you've called scsi_remove_host() the mid-layer will take control of
your in-flight commands (if there are any) and error them back to the
user. You need to take any actions to clean up internal structures
belonging to the commands *before* you do a scsi_remove_host.
James
next prev parent reply other threads:[~2004-09-29 19:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040926082926.GA1944@uniball>
2004-09-27 18:18 ` BUG: CD driver sends command during host removal Alan Stern
2004-09-27 18:51 ` Mohammed Sameer
2004-09-29 16:06 ` Luben Tuikov
2004-09-29 16:55 ` Alan Stern
2004-09-29 17:09 ` Mike Anderson
2004-09-29 18:02 ` Luben Tuikov
2004-09-29 18:09 ` James Bottomley
2004-09-29 18:58 ` Luben Tuikov
2004-09-29 19:39 ` James Bottomley
2004-09-29 19:01 ` Alan Stern
2004-09-29 19:27 ` Mike Anderson
2004-09-29 19:33 ` Luben Tuikov
2004-09-29 19:50 ` James Bottomley [this message]
2004-09-29 20:31 ` Mike Anderson
2004-09-29 20:41 ` James Bottomley
2004-09-29 21:07 ` Mike Anderson
2004-09-29 21:14 ` James Bottomley
2004-09-29 21:20 ` Luben Tuikov
2004-09-29 21:26 ` James Bottomley
2004-09-29 21:20 ` Alan Stern
2004-10-02 23:57 ` Mohammed Sameer
2004-10-11 19:20 Alan Stern
2004-10-11 19:36 ` James Bottomley
2004-10-11 20:03 ` Alan Stern
2004-10-11 20:12 ` James Bottomley
2004-10-11 20:40 ` Mike Anderson
2004-10-11 21:15 ` James Bottomley
2004-10-11 23:13 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096487461.2028.134.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb-users@lists.sourceforge.net \
--cc=luben_tuikov@adaptec.com \
--cc=stern@rowland.harvard.edu \
--cc=uniball@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).