From: James Bottomley <James.Bottomley@SteelEye.com>
To: Mike Anderson <andmike@us.ibm.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Luben Tuikov <luben_tuikov@adaptec.com>,
SCSI development list <linux-scsi@vger.kernel.org>,
Mohammed Sameer <uniball@gmx.net>,
USB users list <linux-usb-users@lists.sourceforge.net>
Subject: Re: BUG: CD driver sends command during host removal
Date: 29 Sep 2004 16:41:05 -0400 [thread overview]
Message-ID: <1096490471.2028.140.camel@mulgrave> (raw)
In-Reply-To: <20040929203104.GB6179@us.ibm.com>
On Wed, 2004-09-29 at 16:31, Mike Anderson wrote:
> James Bottomley [James.Bottomley@SteelEye.com] wrote:
> > Once you've called scsi_remove_host() the mid-layer will take control of
> > your in-flight commands (if there are any) and error them back to the
> > user. You need to take any actions to clean up internal structures
> > belonging to the commands *before* you do a scsi_remove_host.
> >
>
> How do we address the problem we get into with the reordering in
> scsi_remove_host (i.e. the call to scsi_forget_host prior to
> scsi_host_cancel) if we possibly generate new io from sd_sync_cache
> that will cause the error handler to fire up if the LLDD just lets the
> command fall on the floor with no response.
That's why LLD's are responsible for erroring all commands issued at
this time if the removal is a surprise ejection. The commands have to
be errored in a way (like DID_NO_CONNECT) that won't excite the error
handler.
James
next prev parent reply other threads:[~2004-09-29 20:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040926082926.GA1944@uniball>
2004-09-27 18:18 ` BUG: CD driver sends command during host removal Alan Stern
2004-09-27 18:51 ` Mohammed Sameer
2004-09-29 16:06 ` Luben Tuikov
2004-09-29 16:55 ` Alan Stern
2004-09-29 17:09 ` Mike Anderson
2004-09-29 18:02 ` Luben Tuikov
2004-09-29 18:09 ` James Bottomley
2004-09-29 18:58 ` Luben Tuikov
2004-09-29 19:39 ` James Bottomley
2004-09-29 19:01 ` Alan Stern
2004-09-29 19:27 ` Mike Anderson
2004-09-29 19:33 ` Luben Tuikov
2004-09-29 19:50 ` James Bottomley
2004-09-29 20:31 ` Mike Anderson
2004-09-29 20:41 ` James Bottomley [this message]
2004-09-29 21:07 ` Mike Anderson
2004-09-29 21:14 ` James Bottomley
2004-09-29 21:20 ` Luben Tuikov
2004-09-29 21:26 ` James Bottomley
2004-09-29 21:20 ` Alan Stern
2004-10-02 23:57 ` Mohammed Sameer
2004-10-11 19:20 Alan Stern
2004-10-11 19:36 ` James Bottomley
2004-10-11 20:03 ` Alan Stern
2004-10-11 20:12 ` James Bottomley
2004-10-11 20:40 ` Mike Anderson
2004-10-11 21:15 ` James Bottomley
2004-10-11 23:13 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096490471.2028.140.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=andmike@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb-users@lists.sourceforge.net \
--cc=luben_tuikov@adaptec.com \
--cc=stern@rowland.harvard.edu \
--cc=uniball@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox