From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] tmscsim: improve tagging Date: 19 Oct 2004 09:01:55 -0500 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <1098194521.2068.6.camel@mulgrave> References: <20041019131051.GN16153@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from stat16.steeleye.com ([209.192.50.48]:8648 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S269416AbUJSOC0 (ORCPT ); Tue, 19 Oct 2004 10:02:26 -0400 In-Reply-To: <20041019131051.GN16153@parcelfarce.linux.theplanet.co.uk> List-Id: linux-scsi@vger.kernel.org To: Matthew Wilcox Cc: Guennadi Liakhovetski , SCSI Mailing List On Tue, 2004-10-19 at 08:10, Matthew Wilcox wrote: > Isn't cmd_per_lun set to only use one tag with this patch? No, it's the depth associated with untagged devices. Arguably it should always be 2 so that there's always one command executing and one fully prepped and waiting to roll, but the driver must know to reject the second command with SCSI_MLQUEUE_DEVICE_BUSY to get it to requeue fully prepared. James