From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: janitor@sternwelten.at,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
nacc@us.ibm.com
Subject: RE: [patch 08/10] scsi/dpt_i2o: replace schedule_timeout() with msleep_interruptible()
Date: 21 Oct 2004 08:50:32 -0400 [thread overview]
Message-ID: <1098363038.1776.4.camel@mulgrave> (raw)
In-Reply-To: <60807403EABEB443939A5A7AA8A7458B40B5B1@otce2k01.adaptec.com>
On Thu, 2004-10-21 at 07:44, Salyzyn, Mark wrote:
> The timeout granularity of 1 second should be the first clue that this
> is not important. Commands complete and wake up the task under normal
> operation; the timeout is to deal with an errant controller.
Erm, yes, but what you're doing is clearly incorrect, and the reason we
went to msleep variants anyway. Your code forgets to set the current
state, so you stand a good chance of returning immediately from the
schedule_timeout() without even yielding the processor.
James
next prev parent reply other threads:[~2004-10-21 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 11:44 [patch 08/10] scsi/dpt_i2o: replace schedule_timeout() with msleep_interruptible() Salyzyn, Mark
2004-10-21 12:50 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-21 8:47 janitor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098363038.1776.4.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=janitor@sternwelten.at \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox