From: Jason Yan <yanaijie@huawei.com>
To: Xingui Yang <yangxingui@huawei.com>, <john.g.garry@oracle.com>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <liyihang9@h-partners.com>,
<liuyonglong@huawei.com>, <kangfenglong@huawei.com>
Subject: Re: [PATCH v2 2/3] scsi: libsas: add lldd_dev_info_update callback for device info changes
Date: Wed, 13 May 2026 14:22:26 +0800 [thread overview]
Message-ID: <10a157bd-78aa-4b8e-9587-4e89afd85ea2@huawei.com> (raw)
In-Reply-To: <20260513021603.3023329-3-yangxingui@huawei.com>
在 2026/5/13 10:16, Xingui Yang 写道:
> When a device attached to an expander phy experiences a linkrate change
> (e.g., due to cable reconnection or negotiation), the current code in
> sas_rediscover_dev() treats it as "broadcast flutter" and takes no action
> if the SAS address and device type remain unchanged.
>
> However, for drivers like hisi_sas, the ITCT entry needs to be updated
> to reflect the new linkrate. Without this update, the hardware continues
> using stale linkrate information, which can cause performance issues or
> protocol errors.
>
> Introduce a new LLDD callback lldd_dev_info_update() to notify the
> low-level driver when a device's information changes (such as linkrate),
> allowing the driver to update its hardware structures accordingly. This
> callback is designed to be extensible for future device information
> updates.
>
> Signed-off-by: Xingui Yang<yangxingui@huawei.com>
> ---
> drivers/scsi/libsas/sas_discover.c | 12 ++++++++++++
> drivers/scsi/libsas/sas_expander.c | 13 +++++++++++--
> drivers/scsi/libsas/sas_internal.h | 1 +
> include/scsi/libsas.h | 1 +
> 4 files changed, 25 insertions(+), 2 deletions(-)
Reviewed-by: Jason Yan <yanaijie@huawei.com>
next prev parent reply other threads:[~2026-05-13 6:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 2:16 [PATCH v2 0/3] scsi: libsas: handle linkrate change in sas_rediscover_dev Xingui Yang
2026-05-13 2:16 ` [PATCH v2 1/3] scsi: libsas: refactor sas_ex_to_ata() using new helper sas_ex_to_dev() Xingui Yang
2026-05-13 6:18 ` Jason Yan
2026-05-13 2:16 ` [PATCH v2 2/3] scsi: libsas: add lldd_dev_info_update callback for device info changes Xingui Yang
2026-05-13 6:22 ` Jason Yan [this message]
2026-05-13 2:16 ` [PATCH v2 3/3] scsi: hisi_sas: add support for dev info update notification Xingui Yang
2026-05-13 6:23 ` Jason Yan
2026-05-13 7:29 ` [PATCH v2 0/3] scsi: libsas: handle linkrate change in sas_rediscover_dev John Garry
2026-05-13 8:14 ` yangxingui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10a157bd-78aa-4b8e-9587-4e89afd85ea2@huawei.com \
--to=yanaijie@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=kangfenglong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=liyihang9@h-partners.com \
--cc=martin.petersen@oracle.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox