Fw: [Bugme-new] [Bug 3753] New: multiple definition of `ST_partstat'

Fw: [Bugme-new] [Bug 3753] New: multiple definition of `ST_partstat'

[Andrew Morton]

Begin forwarded message:

Date: Tue, 16 Nov 2004 10:43:01 -0800
From: bugme-daemon@osdl.org
To: bugme-new@lists.osdl.org
Subject: [Bugme-new] [Bug 3753] New: multiple definition of `ST_partstat'


http://bugme.osdl.org/show_bug.cgi?id=3753

           Summary: multiple definition of `ST_partstat'
    Kernel Version: 2.6.10-rc2
            Status: NEW
          Severity: blocking
             Owner: andmike@us.ibm.com
         Submitter: selecter@spray.se


Distribution: Debian Sarge

Problem Description:
  LD      drivers/scsi/sd_mod.o
  CC      drivers/scsi/sg.o
  LD      drivers/scsi/built-in.o
drivers/scsi/osst.o(.bss+0x0): multiple definition of `ST_partstat'
drivers/scsi/st.o(.bss+0x0): first defined here
make[2]: *** [drivers/scsi/built-in.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Re: Fw: [Bugme-new] [Bug 3753] New: multiple definition of `ST_partstat'

[James Bottomley]

On Tue, 2004-11-16 at 13:19, Andrew Morton wrote:
> Problem Description:
>   LD      drivers/scsi/sd_mod.o
>   CC      drivers/scsi/sg.o
>   LD      drivers/scsi/built-in.o
> drivers/scsi/osst.o(.bss+0x0): multiple definition of `ST_partstat'
> drivers/scsi/st.o(.bss+0x0): first defined here
> make[2]: *** [drivers/scsi/built-in.o] Error 1
> make[1]: *** [drivers/scsi] Error 2
> make: *** [drivers] Error 2

Kai,

This looks like a missed piece in a typedef conversion in st.h from the
patch SCSI tape: remove remaining typedefs.

James

===== drivers/scsi/st.h 1.20 vs edited =====
--- 1.20/drivers/scsi/st.h	2004-10-25 13:32:30 -05:00
+++ edited/drivers/scsi/st.h	2004-11-16 13:30:48 -06:00
@@ -67,7 +67,7 @@
 	u32 last_block_visited;
 	int drv_block;		/* The block where the drive head is */
 	int drv_file;
-} ST_partstat;
+};
 
 #define ST_NBR_PARTITIONS 4
 

Re: Fw: [Bugme-new] [Bug 3753] New: multiple definition of `ST_partstat'

[Kai Makisara]

On Tue, 16 Nov 2004, James Bottomley wrote:

> On Tue, 2004-11-16 at 13:19, Andrew Morton wrote:
> > Problem Description:
> >   LD      drivers/scsi/sd_mod.o
> >   CC      drivers/scsi/sg.o
> >   LD      drivers/scsi/built-in.o
> > drivers/scsi/osst.o(.bss+0x0): multiple definition of `ST_partstat'
> > drivers/scsi/st.o(.bss+0x0): first defined here
> > make[2]: *** [drivers/scsi/built-in.o] Error 1
> > make[1]: *** [drivers/scsi] Error 2
> > make: *** [drivers] Error 2
> 
> Kai,
> 
> This looks like a missed piece in a typedef conversion in st.h from the
> patch SCSI tape: remove remaining typedefs.
> 
> James
> 
> ===== drivers/scsi/st.h 1.20 vs edited =====
> --- 1.20/drivers/scsi/st.h	2004-10-25 13:32:30 -05:00
> +++ edited/drivers/scsi/st.h	2004-11-16 13:30:48 -06:00
> @@ -67,7 +67,7 @@
>  	u32 last_block_visited;
>  	int drv_block;		/* The block where the drive head is */
>  	int drv_file;
> -} ST_partstat;
> +};
>  
>  #define ST_NBR_PARTITIONS 4
>  
Yes. One more reminder that I should _never_ forget to re-add osst to the 
kernel configuration if I temporarily remove it ;-(

Thanks to all involved in noticing and fixing this bug.
-- 
Kai