From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jens Axboe <axboe@suse.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
achim_leubner@adaptec.com
Subject: Re: [PATCH] gdth buggy page mapping
Date: 23 Nov 2004 12:44:57 -0600 [thread overview]
Message-ID: <1101235504.2016.14.camel@mulgrave> (raw)
In-Reply-To: <20041123180622.GK13174@suse.de>
Actually, this:
On Tue, 2004-11-23 at 12:06, Jens Axboe wrote:
> @@ -2717,8 +2716,8 @@
> if (scp->use_sg) {
> sl = (struct scatterlist *)scp->request_buffer;
> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,13)
> - sgcnt = pci_map_sg(ha->pdev,sl,scp->use_sg,PCI_DMA_FROMDEVICE);
> - for (i=0,cpsum=0; i<sgcnt; ++i,++sl) {
> + for (i=0,cpsum=0; i<scp->use_sg; ++i,++sl) {
> + unsigned long flags;
> cpnow = (ushort)sg_dma_len(sl);
Won't quite work any more. On most platforms, it will since
sg_dma_len(sl) expands to sl->length which is the correct thing.
However, on some, like parisc, x86_64, ppc64 it will expand to a
different parameter which won't get filled in if the dma mapping is
never done. I think all use of the sg_dma_ macros in this driver will
need modifying with this change.
James
next prev parent reply other threads:[~2004-11-23 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-23 18:06 [PATCH] gdth buggy page mapping Jens Axboe
2004-11-23 18:44 ` James Bottomley [this message]
2004-11-23 19:13 ` Jens Axboe
2004-11-23 19:19 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101235504.2016.14.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=achim_leubner@adaptec.com \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox