Re: [patch 6/8] mptfusion: fc transport

James Bottomley
2004-11-26T19:30:47Z

On Fri, 2004-11-19 at 09:39, Moore, Eric Dean wrote:
> This provides fc_transport support, exporting
> port_id, port_name, node_name.

This:

@@ -4,6 +4,7 @@
config FUSION
tristate "Fusion MPT (base + ScsiHost) drivers"
depends on PCI && SCSI
+ select SCSI_FC_ATTRS
---help---

Doesn't look correct. It will force the FC attrs to be built even if
you're only building for a purely SPI device. Worse, module
dependencies will force the FC transport to load even if you're only
attaching to a SCSI device. This isn't really optimal, especially as
the FC transport class is growing in size now.

How difficult would it be to separate out the scsi and FC pieces of the
fusion driver, so we could allow more fined grained control of this?

James