From: James Bottomley <James.Bottomley@SteelEye.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: "Jose R. Santos" <jrsantos@austin.ibm.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: phase change messages cusing slowdown with sym53c8xx_2 driver
Date: 01 Dec 2004 15:43:02 -0500 [thread overview]
Message-ID: <1101933788.1930.226.camel@mulgrave> (raw)
In-Reply-To: <20041201203226.GI5752@parcelfarce.linux.theplanet.co.uk>
On Wed, 2004-12-01 at 15:32, Matthew Wilcox wrote:
> On Wed, Dec 01, 2004 at 12:16:33PM -0500, James Bottomley wrote:
> > does this look like the "drive won't respond properly to PPR if the bus
> > is SE" problem again?
>
> Thomas Babut who tested that fix reported it didn't solve his problem ;-(
>
> http://marc.theaimsgroup.com/?l=linux-scsi&m=109968716312783&w=2
> http://marc.theaimsgroup.com/?l=linux-scsi&m=109969829411685&w=2
>
> I'm out of ideas for fixing that one. Would you consider Richard
> Waltham's patch?
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=109967237930243&w=2
Actually, yes, or the attached variant of it. Does this solve the
problem?
There's no reason why we should assume a SCSI_3 or greater device
automatically supports ppr (especially if it's inquiry bit is
advertising that it doesn't...)
James
===== drivers/scsi/scsi_scan.c 1.134 vs edited =====
--- 1.134/drivers/scsi/scsi_scan.c 2004-10-24 07:09:48 -04:00
+++ edited/drivers/scsi/scsi_scan.c 2004-12-01 15:41:03 -05:00
@@ -554,10 +554,8 @@
sdev->removable = (0x80 & inq_result[1]) >> 7;
sdev->lockable = sdev->removable;
sdev->soft_reset = (inq_result[7] & 1) && ((inq_result[3] & 7) == 2);
+ sdev->ppr = (sdev->inquiry_len > 56 && (inq_result[56] & 0x04) == 0x04);
- if (sdev->scsi_level >= SCSI_3 || (sdev->inquiry_len > 56 &&
- inq_result[56] & 0x04))
- sdev->ppr = 1;
if (inq_result[7] & 0x60)
sdev->wdtr = 1;
if (inq_result[7] & 0x10)
next prev parent reply other threads:[~2004-12-01 20:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 3:02 phase change messages cusing slowdown with sym53c8xx_2 driver Jose R. Santos
2004-12-01 16:56 ` Jose R. Santos
2004-12-01 17:16 ` James Bottomley
2004-12-01 20:32 ` Matthew Wilcox
2004-12-01 20:43 ` James Bottomley [this message]
2004-12-01 21:22 ` Jose R. Santos
2004-12-01 23:34 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101933788.1930.226.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=jrsantos@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox